Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wording grammar folder security and language #2034

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

PhilDaiguille
Copy link
Contributor

@PhilDaiguille PhilDaiguille commented Feb 4, 2025

This pull request includes various minor corrections to grammar and spelling in multiple XML files. The changes are primarily focused on improving the readability and accuracy of the documentation.

Grammar and spelling corrections:

language/constants.xml Outdated Show resolved Hide resolved
@PhilDaiguille PhilDaiguille force-pushed the fix/wording-grammar-text branch from 16a2509 to 3344141 Compare February 4, 2025 15:06
security/database.xml Outdated Show resolved Hide resolved
security/errors.xml Outdated Show resolved Hide resolved
language/enumerations.xml Outdated Show resolved Hide resolved
@PhilDaiguille PhilDaiguille force-pushed the fix/wording-grammar-text branch 2 times, most recently from cfa9db2 to c68dde9 Compare February 4, 2025 15:19
Copy link
Contributor

@Fan2Shrek Fan2Shrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

language/enumerations.xml Outdated Show resolved Hide resolved
@Fan2Shrek
Copy link
Contributor

After checking the en files, the double spaces are present there too and should be fixed in en first.

@PhilDaiguille
Copy link
Contributor Author

@Fan2Shrek
Copy link
Contributor

Thanks a lot for the fix! Now, we need to update the revision commit at the start of the changed files
(with f4f96ef8b2a95283c92ea2183fe1dedf06f3ad22)

@PhilDaiguille PhilDaiguille force-pushed the fix/wording-grammar-text branch 4 times, most recently from b3bf2cd to f8f7d06 Compare February 5, 2025 12:14
@PhilDaiguille PhilDaiguille force-pushed the fix/wording-grammar-text branch from f8f7d06 to 26f0002 Compare February 5, 2025 13:14
@PhilDaiguille PhilDaiguille force-pushed the fix/wording-grammar-text branch from 26f0002 to 5d2e419 Compare February 5, 2025 13:18
@Fan2Shrek Fan2Shrek merged commit 2c2dcd1 into php:master Feb 5, 2025
1 check passed
@Fan2Shrek
Copy link
Contributor

Thanks @PhilDaiguille nice catches 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants