testing php 8.4

phparkitect · Feb 10, 2025 · acf3a81 · acf3a81
1 parent e162c85
commit acf3a81
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
+        php-versions: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
         coverage-driver: [ 'pcov' ]
 
     steps:
@@ -58,7 +58,7 @@ jobs:
         token: ${{ secrets.CODECOV_TOKEN }}
 
   phar:
-    runs-on: "ubuntu-20.04"
+    runs-on: "ubuntu-22.04"
     needs: build
     steps:
       - uses: actions/checkout@v3
@@ -92,10 +92,10 @@ jobs:
 
   smoke-test-phar:
     needs: phar
-    runs-on: "ubuntu-20.04"
+    runs-on: "ubuntu-22.04"
     strategy:
       matrix:
-        php-versions: [ '7.2', '7.3', '7.4', '8.0', '8.1' ]
+        php-versions: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
         coverage-driver: [ 'pcov' ]
 
     steps:
@@ -117,7 +117,7 @@ jobs:
 
   publish_phar:
     needs: [build, smoke-test-phar]
-    runs-on: "ubuntu-20.04"
+    runs-on: "ubuntu-22.04"
     if: github.event_name == 'release'
     steps:
       - name: "Download phar ./phparkitect-${{ github.sha }}.phar"

diff --git a/src/CLI/TargetPhpVersion.php b/src/CLI/TargetPhpVersion.php
@@ -16,6 +16,7 @@ class TargetPhpVersion
         '8.1',
         '8.2',
         '8.3',
+        '8.4',
     ];
 
     /** @var string|null */
@@ -25,7 +26,7 @@ private function __construct(string $version)
     {
         $versionNumbers = explode('.', $version);
         if (3 <= \count($versionNumbers)) {
-            $version = $versionNumbers[0].'.'.$versionNumbers[1];
+            $version = $versionNumbers[0] . '.' . $versionNumbers[1];
         }
 
         if (!\in_array($version, self::VALID_PHP_VERSIONS)) {