support php 8.4 #441
Open
support php 8.4 #441
+1,109
−865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @nikow13! |
|
Related psalm issue and MR about PHP 8.4 support: |
|
Psalm 6 has been released which supports php 8.4 |
|
ready to go? |
|
looks like php version used for running scrutinizer needs to be bumped |
Yes, it seems that Scrutinizer is managed outside the code, so I can’t update it |
|
We are verifying it :) |
| @@ -1,8 +1,8 @@ | |||
| ARG PHP_VERSION=7.1 | |||
| ARG PHP_VERSION=8.4 | |||
There was a problem hiding this comment.
Why the version 8.4 and not the minor that we can support?
There was a problem hiding this comment.
for local testing with the last version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the codebase for PHP 8.4 compatibility and upgrades Psalm to version 6.0. Some errors were introduced with the Psalm update, so I’ve added a baseline for now to prevent build issues