Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with phpstan/phpdoc-parser v2 #442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmilMassey
Copy link

@EmilMassey EmilMassey commented Jan 2, 2025

This PR adds compatibility for phpstan/phpdoc-parser v2 while maintaining support for v1.

Currently check are failing due to invalid code style: see #443 for the fix.

@micheleorselli
Copy link
Contributor

The build pipeline is fixed so by rebasing to master you should be able to get all the checks passing.
Apart from that, what are the advantages of using version 2 of the parser? Consider we decided to drop php 7 support so we could just support version 2 and that's it. cc @AlessandroMinoccheri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants