Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes support for php 7.1 #446

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Removes support for php 7.1 #446

merged 6 commits into from
Feb 10, 2025

Conversation

micheleorselli
Copy link
Contributor

@micheleorselli micheleorselli commented Feb 8, 2025

This is a first step in order to drop support for php 7. Here I am removing support php 7.1 which was causing problems in the pipeline due to old symfony/process versions with security bugs and a too much wide version for phpcsfixer which resulted in different version installed based on the php version, leading to inconsistent results

This would also unblock the merging of #444.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.06%. Comparing base (cc81afc) to head (1eea832).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #446   +/-   ##
=========================================
  Coverage     94.06%   94.06%           
  Complexity      601      601           
=========================================
  Files            69       69           
  Lines          1551     1551           
=========================================
  Hits           1459     1459           
  Misses           92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micheleorselli micheleorselli marked this pull request as ready for review February 8, 2025 20:56
@micheleorselli micheleorselli merged commit e162c85 into main Feb 10, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants