Add ArrayFindFunctionReturnTypeExtension #3518
Conversation
| function testConstant(array $array, callable $callback): void | ||
| { | ||
| assertType("1|'foo'|DateTime|null", array_find($array, $callback)); | ||
| assertType("1|null", array_find($array, 'is_int')); |
There was a problem hiding this comment.
This cannot be Null.
| function testMixed(array $array, callable $callback): void | ||
| { | ||
| assertType('mixed', array_find($array, $callback)); | ||
| assertType('int|null', array_find($array, 'is_int')); |
There was a problem hiding this comment.
You should also test it on non empty array, and the result should be an int
There was a problem hiding this comment.
It seems like it can be improved at the same time as array_filter().
| function testConstant(array $array, callable $callback): void | ||
| { | ||
| assertType("0|1|2|null", array_find_key($array, $callback)); | ||
| assertType("0|1|2|null", array_find_key($array, 'is_int')); |
There was a problem hiding this comment.
Ideally, that's correct. This PR does not implement the logic to detect this.
There was a problem hiding this comment.
What's the current behavior ? I assume the type is considered as mixed.
This means that merging the PR as if will introduce a lot of false positif PHPstan errors on level 7 (unions) when it's currently on level 9 (mixed).
That's why IMHO if a dynamic return type extension is introduced, the implementation need to handle such case.
There was a problem hiding this comment.
What's the current behavior ? I assume the type is considered as mixed.
just copy the test over into the playground:
https://phpstan.org/r/ece55e5c-33bf-47cb-b538-35708d025dfa
| function testMixed(array $array, callable $callback): void | ||
| { | ||
| assertType('int|string|null', array_find_key($array, $callback)); | ||
| assertType('int|string|null', array_find_key($array, 'is_int')); |
There was a problem hiding this comment.
You should test on non-empty-array and it should gives int|string
There was a problem hiding this comment.
We can add a test case, but if you pass a non-empty-array<mixed> the function may return any int|string|null.
zonuexe
force-pushed
the
feature/array_find
branch
from
581fba3
to
7dd1e43
Compare
Supports PHP RFC: array_find for PHP 8.4.