Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_backup: add lock for truncating (#49469) #49709

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49469

What problem does this PR solve?

Issue Number: close #49414

Problem Summary:
See the issue.

What changed and how does it work?

This PR added a lock while we are doing truncating.
The lock will be send with metadata of the node that locks the storage, so other can read the lock and decide whether it is valid.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
image - [ ] No need to test > - [ ] I checked and no code files have been changed. >

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Concurrent run of log truncate will cause fail now.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 22, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2023
Signed-off-by: hillium <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 25, 2023
Signed-off-by: hillium <[email protected]>
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 26, 2023
Copy link

ti-chi-bot bot commented Dec 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 26, 2023
Copy link

ti-chi-bot bot commented Dec 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-25 03:43:40.101774062 +0000 UTC m=+1450911.139000990: ☑️ agreed by YuJuncen.
  • 2023-12-26 04:30:34.623026761 +0000 UTC m=+1540125.660253705: ☑️ agreed by BornChanger.

Signed-off-by: hillium <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 26, 2023
@BornChanger
Copy link
Contributor

/retest

@YuJuncen
Copy link
Contributor

/test-mysql-test

@BornChanger
Copy link
Contributor

/retest

@YuJuncen
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Dec 26, 2023

@YuJuncen: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YuJuncen
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Dec 27, 2023

@YuJuncen: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@13eeb6a). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #49709   +/-   ##
================================================
  Coverage               ?   73.7399%           
================================================
  Files                  ?       1088           
  Lines                  ?     350415           
  Branches               ?          0           
================================================
  Hits                   ?     258396           
  Misses                 ?      75497           
  Partials               ?      16522           

@ti-chi-bot ti-chi-bot bot merged commit a0289e9 into pingcap:release-6.5 Dec 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants