-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log_backup: add lock for truncating (#49469) #49709
log_backup: add lock for truncating (#49469) #49709
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: hillium <[email protected]>
/retest |
/test-mysql-test |
/retest |
/test mysql-test |
@YuJuncen: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@YuJuncen: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #49709 +/- ##
================================================
Coverage ? 73.7399%
================================================
Files ? 1088
Lines ? 350415
Branches ? 0
================================================
Hits ? 258396
Misses ? 75497
Partials ? 16522 |
This is an automated cherry-pick of #49469
What problem does this PR solve?
Issue Number: close #49414
Problem Summary:
See the issue.
What changed and how does it work?
This PR added a lock while we are doing truncating.
The lock will be send with metadata of the node that locks the storage, so other can read the lock and decide whether it is valid.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.