Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix unique key get wrong row count when to query the NULL value | tidb-test=pr/2476 #56277

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56117

What problem does this PR solve?

Issue Number: close #56116

Problem Summary:

What changed and how does it work?

There will be issues with the row count under index/unique index. Previously, we would uniformly count the row count for this PointGet as 1, but if it is null, it will no longer be 1 and must be calculated according to the null count.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

From internal test cases

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved labels Sep 25, 2024
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 5, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2025
@hawkingrei hawkingrei changed the title planner: fix unique key get wrong row count when to query the NULL value | tidb-test=pr/2390 (#56117) planner: fix unique key get wrong row count when to query the NULL value | tidb-test=pr/2475 Feb 5, 2025
@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@hawkingrei hawkingrei changed the title planner: fix unique key get wrong row count when to query the NULL value | tidb-test=pr/2475 planner: fix unique key get wrong row count when to query the NULL value | tidb-test=pr/2476 Feb 5, 2025
@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@116ffee). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #56277   +/-   ##
================================================
  Coverage               ?   73.6305%           
================================================
  Files                  ?       1097           
  Lines                  ?     353124           
  Branches               ?          0           
================================================
  Hits                   ?     260007           
  Misses                 ?      76382           
  Partials               ?      16735           

@hawkingrei hawkingrei requested review from fixdb and winoros February 5, 2025 10:58
Copy link

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2025
Copy link

ti-chi-bot bot commented Feb 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 09:22:43.623955725 +0000 UTC m=+263635.156367721: ☑️ agreed by hawkingrei.
  • 2025-02-05 11:01:18.419943021 +0000 UTC m=+269549.952355020: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 655a986 into pingcap:release-6.5 Feb 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants