-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: move UpdateStatsHealthyMetrics into updateStatsWorker (#55386) #56323
domain: move UpdateStatsHealthyMetrics into updateStatsWorker (#55386) #56323
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #56323 +/- ##
================================================
Coverage ? 73.6226%
================================================
Files ? 1097
Lines ? 353098
Branches ? 0
================================================
Hits ? 259960
Misses ? 76400
Partials ? 16738 |
This is an automated cherry-pick of #55386
What problem does this PR solve?
Issue Number: ref #54552
Problem Summary:
What changed and how does it work?
move UpdateStatsHealthyMetrics into updateStatsWorker. This way, it will not compete for resources with sync statistic. because we find that sync stats will pause for too much time to sync stats as soon as possible. it will lead to miss some stats to sync.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.