-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: watch the ddl ownerkey with the createRevision (#55692) #57041
ddl: watch the ddl ownerkey with the createRevision (#55692) #57041
Conversation
Signed-off-by: joccau <[email protected]>
1b8f809
to
921f9eb
Compare
…ry-pick-55692-to-release-6.5
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #57041 +/- ##
================================================
Coverage ? 73.7181%
================================================
Files ? 1097
Lines ? 353495
Branches ? 0
================================================
Hits ? 260590
Misses ? 76219
Partials ? 16686 |
Signed-off-by: joccau <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joccau, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #55692
What problem does this PR solve?
A tidb-server run campaignOwner successfully and become owner. If it watches the owner after the ownerKey is deleted, the watchOwner() will be stuck.
The method to fix it: need to watch the owner since createRevision.
Issue Number: close #54689, ref #54436
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.