Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: rightly deal with timout when to send sync load (#57712) #57754

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57712

What problem does this PR solve?

Issue Number: close #57710

Problem Summary:

What changed and how does it work?

in the origin code, we can not check the timeout after sending the sync load. so it will block the sending sync load and take too much time.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

rightly deal with timout when to send sync load

正确处理发送 sync load 的超时

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 27, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2024
@hawkingrei
Copy link
Member

/test abc

@pingcap pingcap deleted a comment from ti-chi-bot bot Dec 2, 2024
@pingcap pingcap deleted a comment from tiprow bot Dec 2, 2024
@pingcap pingcap deleted a comment from tiprow bot Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 5, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2025
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2025
@hawkingrei hawkingrei force-pushed the cherry-pick-57712-to-release-6.5 branch from acec815 to 848bdab Compare February 5, 2025 08:17
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2025
Copy link

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2025
Copy link

ti-chi-bot bot commented Feb 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 07:41:17.542815155 +0000 UTC m=+257549.075227152: ☑️ agreed by hawkingrei.
  • 2025-02-05 08:35:00.709190206 +0000 UTC m=+260772.241602206: ☑️ agreed by qw4990.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@5f4110d). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #57754   +/-   ##
================================================
  Coverage               ?   73.6888%           
================================================
  Files                  ?       1097           
  Lines                  ?     353382           
  Branches               ?          0           
================================================
  Hits                   ?     260403           
  Misses                 ?      76264           
  Partials               ?      16715           

@ti-chi-bot ti-chi-bot bot merged commit 344b656 into pingcap:release-6.5 Feb 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants