-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: PiTR table filter online support #59281
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
20c175b
to
381e01b
Compare
c92fc12
to
7309304
Compare
7309304
to
0d4d25e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59281 +/- ##
================================================
+ Coverage 73.1153% 74.4271% +1.3118%
================================================
Files 1702 1748 +46
Lines 470060 478426 +8366
================================================
+ Hits 343686 356079 +12393
+ Misses 105188 99744 -5444
- Partials 21186 22603 +1417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
70cff77
to
b1a07db
Compare
Signed-off-by: Wenqi Mou <[email protected]>
e9225a9
to
05b0129
Compare
Signed-off-by: Wenqi Mou <[email protected]>
05b0129
to
ac16ebe
Compare
Signed-off-by: Wenqi Mou <[email protected]>
@Tristan1900: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #59280
Problem Summary:
What changed and how does it work?
Make sure when user wants to use PiTR table filter to restore to an online cluster, the flag --online is specified.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.