-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add size and uploadedAt fields for listFiles #1080
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThe changes in this pull request enhance the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/uploadthing/src/sdk/index.ts (1)
319-319
: LGTM! Consider adding JSDoc comments for the new fields.The addition of
size
anduploadedAt
fields to theListFileResponse
schema aligns well with the PR objectives.Consider adding JSDoc comments to document:
size
: The file size in bytesuploadedAt
: The Unix timestamp of when the file was uploadedAlso applies to: 326-326
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
packages/uploadthing/src/sdk/index.ts
(1 hunks)
🔇 Additional comments (1)
packages/uploadthing/src/sdk/index.ts (1)
319-326
: Successfully implements the requested features from issues #899 and #927.
The schema changes effectively address the requirements by:
- Adding file size information as requested in both issues
- Maintaining the upload status field for tracking file state
- Adding upload timestamp as a bonus feature for better file management
This implementation will improve user experience by providing essential metadata before file downloads.
📦 Bundle size comparison
|
More templates
commit: |
Closes #899
Closes #927
Summary by CodeRabbit
New Features
Bug Fixes
Chores
turbo
dependency version inpackage.json
.next-playground
anddocs
directories.eslint-config-turbo
dependency version in the ESLint configuration package.