chore(release): 📦 version packages #1115
Conversation
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
78861c4 to
71e23cf
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThis pull request involves the removal of a changelog entry and version updates across multiple packages in the UploadThing ecosystem. The changes primarily focus on incrementing versions for packages like Changes
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
301c8ad to
e4c6d50
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
7cb39fe to
bc1cef3
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
98bd447 to
23f8eaf
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
9392825 to
7c45df6
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
e214200 to
28272b6
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/react/CHANGELOG.md (1)
258-259: Fix markdown formatting for URL.The bare URL should be wrapped in angle brackets for better markdown formatting.
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + <https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/expo/CHANGELOG.md (1)
130-131: Add missing comma for better readabilityConsider adding a comma after "sometimes" to improve readability.
- fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` + fix vite monorepos sometimes, complaining about `$RefreshSig$ is not a function`🧰 Tools
🪛 LanguageTool
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md (2)
3-10: Consider enhancing the changelog entry with more details.While the entry follows good practices by including PR/commit links and proper crediting, the description "feat: allow custom fetch override" could be more detailed to help users understand the feature's purpose and usage.
Consider expanding the description to include:
- Why this feature was added
- How users can utilize the custom fetch override
- Any breaking changes or migration notes
303-304: Use proper Markdown link syntax for URLs.Convert the bare URL to proper Markdown link syntax for better maintainability and accessibility.
- https://docs.uploadthing.com/getting-started/svelte + [Svelte Documentation](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (30)
- packages/vue/package.json
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- examples/backend-adapters/server/package.json
- packages/uploadthing/package.json
- packages/svelte/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-remix/package.json
- examples/with-clerk-pagesdir/package.json
- packages/solid/CHANGELOG.md
- packages/solid/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-expo/package.json
- examples/with-novel/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-sveltekit/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-drizzle-appdir/package.json
- packages/expo/package.json
- examples/with-tailwindcss/package.json
- packages/react/package.json
- examples/minimal-nuxt/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~137-~137: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[uncategorized] ~168-~168: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (12)
packages/react/CHANGELOG.md (2)
3-10: LGTM! Latest version changes are well documented.The changelog entry for version 7.2.0 properly documents:
- The minor change allowing custom fetch override
- Links to PR feat: add custom fetch override #1099 and commit hash
- Credits contributor @juliusmarminge
Line range hint
1-534: LGTM! The changelog follows best practices.The changelog:
- Follows the Keep a Changelog format
- Uses semantic versioning
- Properly documents breaking changes
- Tracks dependencies
- Credits contributors
🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM: Version bump and changelog entry are appropriate.The patch version bump to 7.1.6 correctly reflects the dependency update to @uploadthing/[email protected], following semantic versioning principles.
Line range hint
1-241: LGTM: Changelog format is consistent.The changelog maintains a consistent format across all versions, properly documenting:
- Version numbers
- Change types
- PR references
- Commit hashes
- Contributor credits
packages/expo/CHANGELOG.md (1)
3-16: LGTM! Well-structured changelog entry.The changelog entry for version 7.2.0 is properly formatted and accurately documents:
- The new custom fetch override feature
- Credit to contributor @juliusmarminge
- Updated dependency on @uploadthing/react
packages/svelte/CHANGELOG.md (1)
Line range hint
1-309: Well-structured changelog format!The changelog follows the Keep a Changelog format consistently, with proper categorization of changes and clear version history.
🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...(EN_EXCESSIVE_EXCLAMATION)
packages/uploadthing/CHANGELOG.md (1)
3-10: LGTM! The latest version entry is well-documented.The changelog entry for version 7.5.0 is properly formatted and includes:
- Clear description of the minor change (custom fetch override)
- PR reference (feat: add custom fetch override #1099)
- Commit hash reference
- Contributor attribution
examples/profile-picture/package.json (2)
22-22: LGTM! Version updates align with release objectives.The updates to
@uploadthing/react(^7.2.0) anduploadthing(^7.5.0) match the intended release versions mentioned in the PR objectives.Also applies to: 35-35
Line range hint
22-36: Verify dependency compatibility.Let's ensure the updated packages are compatible with other dependencies in the project.
✅ Verification successful
Dependencies are compatible with the project setup
Based on the codebase analysis, the dependencies are compatible:
@uploadthing/[email protected]and[email protected]are being used together in multiple example projects and the core packages- The project uses Next.js 15.1.3, which is compatible with these versions of uploadthing
- The codebase shows consistent usage patterns across different implementations (Next.js App Router, Pages Router, etc.)
- The uploadthing configuration in the project follows the latest API patterns seen in the example implementations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential dependency conflicts and peer dependency requirements # Check if there are any conflicting peer dependencies npm info "@uploadthing/[email protected]" peerDependencies npm info "[email protected]" peerDependencies # Look for any dependency warnings in package-lock.json if [ -f "package-lock.json" ]; then jq '.packages | .[] | select(.dependencies != null) | select(.dependencies["@uploadthing/react"] != null or .dependencies["uploadthing"] != null)' package-lock.json fiLength of output: 890
Script:
#!/bin/bash # Let's try with the latest available versions to understand the peer dependencies npm info "@uploadthing/react" versions npm info "uploadthing" versions # Also check for any usage of these packages in the codebase rg -l "from ['\"]@uploadthing/react['\"]" --type ts --type tsx rg -l "from ['\"]uploadthing['\"]" --type ts --type tsx # Check Next.js version compatibility by looking at the project configuration fd "next.config" --type f --exec cat {}Length of output: 16932
Script:
#!/bin/bash # Let's check for actual usage of these packages in the codebase rg -l "from ['\"]@uploadthing/react['\"]" rg -l "from ['\"]uploadthing['\"]" # Also check for any configuration files related to uploadthing fd "uploadthing.config" --type f --exec cat {} fd "uploadthing" --type f -e ts -e js --exec cat {}Length of output: 54369
packages/vue/CHANGELOG.md (3)
3-10: LGTM! Changelog entry follows conventions.The changelog entry for version 7.2.0 correctly documents the minor feature addition (custom fetch override) and properly credits the contributor. The version bump follows semantic versioning guidelines for feature additions.
Line range hint
1-280: LGTM! Changelog aligns with PR objectives.The changelog updates are consistent with the PR objectives:
- Version bump to 7.2.0 matches other packages
- Custom fetch override feature is documented
- Part of the coordinated release across the UploadThing ecosystem
🧰 Tools
🪛 LanguageTool
[uncategorized] ~168-~168: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
16-19: Verify peer dependency compatibility with new fetch override feature.The relaxed peer dependency requirements from version 7.1.5 should be verified to ensure they support the new custom fetch override feature in version 7.2.0.
✅ Verification successful
Let me gather more information about the fetch override feature to ensure compatibility.
Let me try a different approach to check the fetch-related changes.
Peer dependency changes are compatible with the codebase
Based on the analysis of package.json files and fetch-related code across the repository:
- All client packages (@uploadthing/vue, @uploadthing/react, @uploadthing/solid, @uploadthing/svelte, @uploadthing/expo) consistently require
uploadthing: ^7.2.0as a peer dependency- The relaxed peer dependency requirements mainly affect framework-specific versions (Vue, React, Solid, Svelte)
- The fetch-related code is properly isolated within each package's implementation
The peer dependency changes in v7.1.5 do not interfere with the fetch override functionality, as the core uploadthing package remains properly versioned across all framework implementations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check peer dependencies in package.json for compatibility # Find and display peer dependencies fd -t f "package.json" -x jq -r '.peerDependencies | select(. != null)'Length of output: 619
Script:
#!/bin/bash # Check for fetch override related changes in recent commits and files rg -l "fetch.*override" --type ts --type vue # Look for any fetch-related configurations or types ast-grep --pattern 'interface $_ { $$$ fetch$_?: $_ $$$ }'Length of output: 141
Script:
#!/bin/bash # Search for fetch-related code in TypeScript files rg -l "fetch" --type ts # Check package versions in package.json files fd -t f "package.json" -x jq -r '{name: .name, version: .version, dependencies: .dependencies, peerDependencies: .peerDependencies} | select(.peerDependencies != null)'Length of output: 4276
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
be7cad0 to
8f6da27
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/react/CHANGELOG.md (1)
258-258: Consider wrapping bare URL in angle brackets.The bare URL on line 258 should be wrapped in angle brackets for better markdown formatting.
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + <https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
313-313: Consider wrapping bare URLs in angle brackets for better markdown formatting.The following URLs should be wrapped in angle brackets according to markdown best practices:
- https://github.com/Effect-TS/effect/issues/3057 + <https://github.com/Effect-TS/effect/issues/3057> - https://effect.website/docs/guides/observability/logging#built-in-loggers + <https://effect.website/docs/guides/observability/logging#built-in-loggers> - https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files> - https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>Also applies to: 487-487, 565-565, 712-712
🧰 Tools
🪛 Markdownlint (0.37.0)
313-313: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (2)
3-10: Consider enhancing the feature description.While the changelog entry follows the standard format, it would be helpful to add more context about the benefits and use cases of the custom fetch override feature.
Consider expanding the description like this:
- feat: allow custom fetch override + feat: allow custom fetch override - enables users to provide their own fetch implementation for better control over network requests and compatibility with different environments
303-304: Fix markdown formatting for the documentation URL.The bare URL should be formatted as a proper markdown link.
Apply this change:
- 📚 Read the docs to get started: - https://docs.uploadthing.com/getting-started/svelte + 📚 Read the [docs](https://docs.uploadthing.com/getting-started/svelte) to get started🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (1)
7-10: Consider enhancing the feature documentation.While the changelog entry is correct, it could be more helpful to users by including a brief example or more details about the custom fetch override feature, similar to how the "Go to Definition" feature was documented in version 7.1.0 (lines 76-92).
Example enhancement:
- feat: allow custom fetch override + feat: allow custom fetch override - enables users to provide their own fetch implementation for + greater control over the upload process. Example: + ```ts + useUploadThing({ + endpoint: "imageUploader", + fetch: customFetchImplementation, + }) + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (31)
- packages/vue/package.json
- packages/nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-appdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-pagedir/package.json
- packages/expo/package.json
- packages/expo/CHANGELOG.md
- examples/minimal-sveltekit/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/server/package.json
- examples/with-serveractions/package.json
- examples/with-drizzle-appdir/package.json
- examples/minimal-expo/package.json
- packages/solid/package.json
- examples/minimal-solidstart/package.json
- packages/uploadthing/package.json
- examples/with-clerk-appdir/package.json
- examples/with-clerk-pagesdir/package.json
- examples/backend-adapters/client-react/package.json
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~137-~137: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/solid/CHANGELOG.md
[uncategorized] ~163-~163: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~247-~247: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/solid/CHANGELOG.md (2)
3-10: LGTM! Changelog entry is well-formatted and consistent with PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor version bump for the new feature
- The PR reference (feat: add custom fetch override #1099)
- The commit hash
- Proper attribution to @juliusmarminge
- Clear description of the feature (custom fetch override)
This aligns perfectly with the PR objectives which mention this feature being added across multiple packages.
Line range hint
1-155: Well-structured changelog following best practices.The changelog demonstrates excellent maintenance with:
- Clear version headers and change categorization
- Consistent formatting across versions
- Proper linking of PRs and commits
- Detailed tracking of dependency updates
- Clear attribution to contributors
packages/react/CHANGELOG.md (2)
3-10: LGTM! Latest version entry matches PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor version bump (7.2.0)
- The feature addition allowing custom fetch override
- Proper attribution to contributor @juliusmarminge
- Link to the relevant PR (feat: add custom fetch override #1099)
Line range hint
1-534: Excellent changelog structure and documentation.The changelog follows best practices:
- Clear version headers with semantic versioning
- Organized sections for Major/Minor/Patch changes
- Consistent linking to PRs and commits
- Proper attribution to contributors
- Detailed descriptions of changes
🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
3-10: LGTM! Well-structured changelog entry.The changelog entry for version 7.5.0 follows the standard format with:
- Clear version number
- Proper categorization (Minor Changes)
- Links to PR (feat: add custom fetch override #1099) and commit hash
- Credit to contributor (@juliusmarminge)
- Clear description of changes
packages/svelte/CHANGELOG.md (1)
Line range hint
1-309: LGTM! Changelog updates align with release strategy.The changelog updates are consistent with the PR objectives, showing this is part of a coordinated release across multiple packages. The version bump to 7.2.0 and the addition of the custom fetch override feature align with the changes in other packages.
🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md (2)
3-10: LGTM! Well-structured changelog entry.The new version entry is properly formatted, includes correct PR reference (#1099), credits the contributor, and clearly describes the feature addition. This is consistent with the coordinated release mentioned in the PR objectives.
Line range hint
11-280: LGTM! Previous entries maintain consistent structure.The historical changelog entries follow proper semantic versioning, maintain consistent formatting, and provide clear documentation of changes with appropriate references to PRs and contributors.
🧰 Tools
🪛 LanguageTool
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM: Changelog entry follows the standard format.The new version entry is properly structured with:
- Clear version number (7.1.6)
- Correct categorization as patch change
- Well-formatted dependency update with commit reference
7-9: Verify dependency update aligns with PR objectives.The update to @uploadthing/[email protected] aligns with the PR objectives, which indicate this version introduces custom fetch override capability across all packages.
Run this script to verify version consistency across related packages:
✅ Verification successful
Let me gather more information about the dependency update.
Let me gather one final piece of information to check the specific changes in version 7.2.0.
Based on the search results, I can now make a determination about the dependency update verification.
Dependency update to @uploadthing/[email protected] is correctly aligned with package requirements
The verification shows that:
- The package.json correctly specifies
@uploadthing/vueas a workspace dependency- The CHANGELOG.md properly documents the update to version 7.2.0
- The package is actively used in the codebase:
- Imported and used in module.ts for styles and configuration
- Used in runtime components (dropzone.ts, button.ts)
- Used in composables (useUploadThing.ts)
The update appears to be properly integrated and the version bump is correctly reflected in the dependency declarations and changelog. No issues were found that would impact the package's functionality or integration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version consistency in package.json files # Look for @uploadthing/vue dependency version in package.json # Find and check package.json files fd "package.json" packages/nuxt | xargs cat | jq -r '.dependencies["@uploadthing/vue"] // .devDependencies["@uploadthing/vue"]' # Verify the dependency is listed in changesets fd "CHANGELOG.md" packages/nuxt | xargs rg "@uploadthing/[email protected]"Length of output: 237
Script:
#!/bin/bash # Check the actual changes in the PR for this dependency update rg -A 5 "@uploadthing/vue" packages/nuxt # Check if there are any related configuration or usage changes fd . packages/nuxt -e ts -e vue | xargs rg "uploadthing" # Look for any related changeset files fd . .changeset -e md | xargs catLength of output: 10448
Script:
#!/bin/bash # Check for any commit messages or PR descriptions related to this version rg -B 2 -A 2 "7.2.0" . # Look for any configuration changes related to fetch rg -i "fetch" packages/nuxt/srcLength of output: 102775
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
e9bdd26 to
d4f764b
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/expo/CHANGELOG.md (1)
128-131: Add missing comma in fix descriptionMinor formatting improvement needed.
- Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` + Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function`,🧰 Tools
🪛 LanguageTool
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md (1)
233-236: Consider maintaining a consistent, professional tone in changelog entriesWhile the addition of Vue and Nuxt support is indeed significant, consider removing the exclamation mark to maintain a consistent, professional tone throughout the changelog.
- Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and - nuxt support! + Thanks [@markflorkowski](https://github.com/markflorkowski) - feat: vue and + nuxt support🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (31)
- examples/backend-adapters/client-vanilla/package.json
- packages/vue/package.json
- packages/nuxt/package.json
- examples/backend-adapters/server/package.json
- packages/solid/package.json
- examples/minimal-astro-react/package.json
- examples/with-serveractions/package.json
- examples/minimal-solidstart/package.json
- examples/with-react-image-crop/package.json
- packages/uploadthing/package.json
- examples/with-novel/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-remix/package.json
- examples/backend-adapters/client-vue/package.json
- examples/backend-adapters/package.json
- examples/with-tailwindcss/package.json
- examples/with-drizzle-pagesdir/package.json
- packages/svelte/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-appdir/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-nuxt/package.json
- packages/solid/CHANGELOG.md
- examples/profile-picture/package.json
- packages/expo/package.json
- examples/minimal-appdir/package.json
- examples/minimal-pagedir/package.json
- packages/react/package.json
- examples/minimal-tanstack-start/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~289-~289: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~497-~497: You might be missing the article “the” here.
Context: ... UploadButton progress text going under progress bar - Updated dependencies [[`f0a4ae...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (9)
packages/expo/CHANGELOG.md (2)
3-16: LGTM! Well-structured changelog entry for version 7.2.0The changelog entry properly documents:
- The minor feature addition (custom fetch override)
- PR reference (feat: add custom fetch override #1099) and commit hash
- Credit to contributor (@juliusmarminge)
- Related dependency updates
Line range hint
83-120: Excellent documentation of the "Go to Definition" featureThe changelog entry for version 7.1.0 provides comprehensive documentation with clear examples of the new feature implementation across different use cases.
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! Version update follows semver correctlyThe changelog entry for version 7.1.6 properly documents the dependency update to @uploadthing/[email protected] and follows the conventional format.
74-82: Excellent documentation of the "Go to Definition" feature!The changelog entry provides clear and comprehensive documentation of the feature, including its purpose and usage examples. This significantly enhances developer experience.
packages/vue/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/svelte/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/react/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/uploadthing/CHANGELOG.md (2)
3-10: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature. The version number (7.5.0) differs from the framework packages (7.2.0) which is expected for the core package.
1-1: Overall changelog consistency looks great!The changes are well-coordinated across all packages:
- All framework packages (@uploadthing/vue, @uploadthing/svelte, @uploadthing/react) bumped to 7.2.0
- Core package (uploadthing) bumped to 7.5.0
- All packages consistently document the custom fetch override feature
- All changes are properly linked to PR feat: add custom fetch override #1099 and commit 36b0df6
github-actions
bot
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
d018093 to
5f2ae7f
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
packages/uploadthing/CHANGELOG.md (1)
324-324: Consider wrapping bare URLs in angle brackets.For better markdown linting compliance, consider wrapping bare URLs in angle brackets. For example:
- https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files>Also applies to: 498-498, 576-576, 723-723
🧰 Tools
🪛 Markdownlint (0.37.0)
324-324: null
Bare URL used(MD034, no-bare-urls)
packages/nuxt/CHANGELOG.md (1)
233-236: Consider removing redundant exclamation mark.- Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and nuxt support! + Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and nuxt support🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md (3)
3-10: Consider enhancing the documentation for JsonArray feature.While the patch change is well-documented with PR and commit references, it would be helpful to include more details about:
- The purpose and use cases of the JsonArray feature
- Examples of supported deeply nested object structures
- Any limitations or considerations when using deeply nested objects
342-343: Improve URL formatting in documentation links.The bare URL should be wrapped in angle brackets for better markdown formatting:
- https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>🧰 Tools
🪛 Markdownlint (0.37.0)
343-343: null
Bare URL used(MD034, no-bare-urls)
167-169: Fix typo in documentation.There's a typo in "Multi Part Uplaods":
- Multi Part Uplaods hasve been abstracted away + Multi Part Uploads have been abstracted awaypackages/react/CHANGELOG.md (1)
263-265: Consider wrapping bare URLs in proper markdown links.For better markdown formatting, consider wrapping the URL in proper markdown syntax:
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + [example](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (1)
309-310: Consider wrapping bare URLs in proper markdown links.For better markdown formatting, consider wrapping the URL in proper markdown syntax:
- https://docs.uploadthing.com/getting-started/svelte + [Read the docs](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (40)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
✅ Files skipped from review due to trivial changes (1)
- packages/shared/package.json
🚧 Files skipped from review as they are similar to previous changes (32)
- examples/backend-adapters/server/package.json
- packages/nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-clerk-appdir/package.json
- packages/solid/package.json
- examples/minimal-nuxt/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-drizzle-appdir/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-serveractions/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/expo/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-appdir/package.json
- packages/vue/package.json
- examples/with-tailwindcss/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/package.json
- packages/expo/CHANGELOG.md
- packages/svelte/package.json
- packages/react/package.json
- packages/uploadthing/package.json
- examples/minimal-expo/package.json
- examples/with-novel/package.json
- packages/solid/CHANGELOG.md
- examples/minimal-sveltekit/package.json
- examples/minimal-solidstart/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
324-324: null
Bare URL used
(MD034, no-bare-urls)
498-498: null
Bare URL used
(MD034, no-bare-urls)
576-576: null
Bare URL used
(MD034, no-bare-urls)
723-723: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (4)
packages/uploadthing/CHANGELOG.md (1)
3-21: LGTM! The changelog entry for version 7.5.0 is well structured and informative.The changes are properly categorized into minor and patch changes, with clear references to PR numbers and commit hashes.
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! Version entry follows changelog conventions.The new version entry correctly documents the dependency update to
@uploadthing/[email protected]following the Changesets format.
Line range hint
1-241: LGTM! Well-maintained changelog with consistent formatting.The changelog maintains excellent traceability with PR links, contributor credits, and detailed descriptions for each change.
packages/vue/CHANGELOG.md (1)
3-16: LGTM! Consistent version bump and changes.The version bump to 7.2.0 and the changes are consistent across all packages. The minor change for custom fetch override and the dependency update to @uploadthing/[email protected] are properly documented.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
packages/react/CHANGELOG.md (2)
264-264: Consider using a proper Markdown link format.Instead of using a bare URL, consider using proper Markdown link syntax for better readability and maintainability.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[novel-plugin.ts#L50-L61](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
143-143: Add a comma for better readability.Add a comma after "sometimes" to improve readability of the sentence.
-fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` +fix vite monorepos sometimes, complaining about `$RefreshSig$ is not a function`🧰 Tools
🪛 LanguageTool
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md (1)
309-310: Use proper Markdown link syntax for the documentation URL.Convert the bare URL to proper Markdown link syntax for better accessibility and consistency.
- 📚 Read the docs to get started: - https://docs.uploadthing.com/getting-started/svelte + 📚 [Read the docs to get started](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (4)
3-10: LGTM! The changelog entry is well-formatted.The latest version entry (7.1.6) follows the standard changelog format with proper PR reference, commit hash, and clear description of the changes.
Consider adding more details about:
- The previous behavior with deeply nested objects
- Examples of the fixed functionality
- Any breaking changes or migration steps if applicable
342-343: Format bare URLs as markdown links.Convert bare URLs to proper markdown links for better documentation consistency.
-📚 Read the docs to get started: -https://docs.uploadthing.com/getting-started/svelte +📚 Read the docs to get started: [Svelte Documentation](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
343-343: null
Bare URL used(MD034, no-bare-urls)
453-458: Improve error handling documentation reference.Format the error handling documentation reference as a proper markdown link.
-feat: float error messages to client for UploadThingErrors. Read the -[error handling docs 📚](https://docs.uploadthing.com/errors) to find out -more. +feat: float error messages to client for UploadThingErrors. For more information, +see the [Error Handling Documentation 📚](https://docs.uploadthing.com/errors).
167-172: Enhance major version change documentation.The major version change (7.0.0) would benefit from more detailed documentation.
Consider adding:
- A migration guide from version 6.x to 7.0.0
- Code examples showing the changes in implementation
- Performance benchmarks demonstrating the improvements
- Any potential breaking changes that users should be aware of
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (40)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
✅ Files skipped from review due to trivial changes (1)
- packages/shared/package.json
🚧 Files skipped from review as they are similar to previous changes (32)
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/solid/package.json
- examples/backend-adapters/server/package.json
- packages/expo/CHANGELOG.md
- examples/with-drizzle-appdir/package.json
- packages/vue/package.json
- examples/minimal-pagedir/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-expo/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- examples/backend-adapters/package.json
- examples/with-clerk-appdir/package.json
- examples/with-tailwindcss/package.json
- examples/with-novel/package.json
- packages/solid/CHANGELOG.md
- packages/expo/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-remix/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-nuxt/package.json
- packages/uploadthing/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- packages/react/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-pagesdir/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
324-324: null
Bare URL used
(MD034, no-bare-urls)
498-498: null
Bare URL used
(MD034, no-bare-urls)
576-576: null
Bare URL used
(MD034, no-bare-urls)
723-723: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/react/CHANGELOG.md (1)
3-16: LGTM! The changelog entry for version 7.2.0 is well-structured.The changelog follows the Keep a Changelog format with clear sections for Minor and Patch changes. The PR link (#1099) and commit hash are properly referenced, and credit is given to the contributor (@juliusmarminge).
packages/vue/CHANGELOG.md (2)
3-16: LGTM! Well-structured changelog entry.The new version entry follows the proper changelog format, includes clear attribution, and correctly documents both the minor feature addition and dependency update.
Line range hint
1-286: LGTM! Consistent changelog format maintained.The changelog demonstrates excellent maintenance practices with:
- Consistent formatting across versions
- Clear attribution of changes
- Proper semver versioning
- Detailed documentation of dependencies
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM: Version update follows semantic versioningThe patch version update correctly reflects the dependency update to @uploadthing/[email protected].
74-82: Excellent documentation of the "Go to Definition" featureThe changelog entry provides clear documentation with practical examples, which greatly helps developers understand and implement the feature.
packages/svelte/CHANGELOG.md (2)
3-16: LGTM! Well-structured changelog entry.The new version entry follows the Keep a Changelog format and properly documents all necessary information including version, changes, PR reference, and attribution.
Line range hint
1-315: LGTM! Consistent and well-maintained changelog.The changelog maintains excellent consistency in formatting and structure throughout its history, making it easy to track changes across versions.
🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (3)
3-11: LGTM! Minor changes are well documented.The changelog entry for version 7.5.0 clearly documents the minor changes:
- Custom fetch override feature (PR feat: add custom fetch override #1099)
- Fix for deeply nested objects with JsonArray (PR fix: allow nested objects in
JsonArraytype #1127)The changes align with the PR objectives and follow the conventional changelog format.
12-18: LGTM! Patch changes are properly documented.The patch changes section clearly documents the fix for handling deeply nested objects when using JsonArray, with proper PR and commit references.
19-21: LGTM! Dependencies are properly updated.The dependency updates section correctly documents the update of @uploadthing/shared to version 7.1.6 with proper commit references.
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
cba93a1 to
c882061
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
0a914b9 to
915de23
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/expo/CHANGELOG.md (1)
Line range hint
130-221: Fix typo in version 7.0.3 changelog entry.The changelog entries are well-documented, but there's a minor grammatical issue in the 7.0.3 entry.
Apply this diff to fix the typo:
- Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos sometimes + Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos, sometimespackages/shared/CHANGELOG.md (1)
214-214: Consider wrapping bare URLs in markdown links.For better markdown formatting, consider wrapping the bare URLs in proper markdown link syntax.
For example:
- See upstream issue: https://github.com/Effect-TS/effect/issues/3057 + See upstream issue: [Effect-TS/effect#3057](https://github.com/Effect-TS/effect/issues/3057) - https://docs.uploadthing.com/getting-started/svelte + [https://docs.uploadthing.com/getting-started/svelte](https://docs.uploadthing.com/getting-started/svelte)Also applies to: 343-343
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
337-337: Fix bare URLs in changelogSeveral bare URLs were found in the changelog. These should be wrapped in angle brackets or formatted as proper Markdown links for better compatibility and readability.
Apply these changes:
- https://effect.website/docs/guides/observability/logging#built-in-loggers + <https://effect.website/docs/guides/observability/logging#built-in-loggers> - https://github.com/Effect-TS/effect/issues/3057 + <https://github.com/Effect-TS/effect/issues/3057> - https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files> - https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>Also applies to: 511-511, 589-589, 736-736
🧰 Tools
🪛 Markdownlint (0.37.0)
337-337: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/curvy-rings-own.md
- .changeset/nice-penguins-grow.md
- .changeset/good-tables-jump.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (33)
- packages/vue/package.json
- packages/shared/package.json
- packages/nuxt/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-novel/package.json
- examples/with-serveractions/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-astro-react/package.json
- packages/svelte/package.json
- packages/solid/package.json
- examples/minimal-appdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-clerk-remix/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-solidstart/package.json
- examples/with-clerk-pagesdir/package.json
- examples/backend-adapters/server/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-react-router/package.json
- packages/expo/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-tailwindcss/package.json
- examples/backend-adapters/package.json
- examples/minimal-nuxt/package.json
- examples/with-clerk-appdir/package.json
- packages/uploadthing/package.json
- examples/with-drizzle-appdir/package.json
- examples/profile-picture/package.json
- examples/minimal-expo/package.json
- examples/minimal-tanstack-start/package.json
- packages/solid/CHANGELOG.md
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
337-337: null
Bare URL used
(MD034, no-bare-urls)
511-511: null
Bare URL used
(MD034, no-bare-urls)
589-589: null
Bare URL used
(MD034, no-bare-urls)
736-736: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (9)
packages/nuxt/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is accurate and well-formatted.The patch version bump to 7.1.6 correctly reflects the dependency update to @uploadthing/[email protected].
packages/vue/CHANGELOG.md (1)
3-17: LGTM! Changelog entry is accurate and well-formatted.The minor version bump to 7.2.0 correctly reflects:
- New feature: custom fetch override
- Dependency update: @uploadthing/[email protected]
packages/svelte/CHANGELOG.md (1)
3-17: LGTM! Changelog entry is accurate and well-formatted.The minor version bump to 7.2.0 correctly reflects:
- New feature: custom fetch override
- Dependency update: @uploadthing/[email protected]
packages/react/CHANGELOG.md (1)
3-17: LGTM! Changelog entry is accurate and well-formatted.The minor version bump to 7.2.0 correctly reflects:
- New feature: custom fetch override
- Dependency update: @uploadthing/[email protected]
packages/expo/CHANGELOG.md (2)
3-18: LGTM! Version 7.2.0 changelog entry is well-documented.The changelog entry properly documents:
- The minor change introducing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies with their respective versions and commit references
Line range hint
19-122: LGTM! Recent version entries (7.1.x) are well-documented.The changelog entries properly document all changes with:
- Clear descriptions of changes
- PR references and commit hashes
- Proper categorization of changes (Minor/Patch)
- Detailed examples where necessary (e.g., "Go to Definition" feature in 7.1.0)
packages/shared/CHANGELOG.md (2)
3-10: LGTM! Well-structured changelog entry.The changelog entry follows best practices with proper versioning, categorization, links to PR/commit, contributor attribution, and a clear description of changes.
Line range hint
1-624: Excellent documentation quality and change tracking.The changelog demonstrates high-quality documentation practices:
- Clear categorization of changes (Major/Minor/Patch)
- Detailed descriptions of significant changes
- Code examples for complex features
- Proper tracking of dependency updates
- Clear marking of breaking changes
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
343-343: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove@effect/schemafrom client bundle resulting in up to 15kB less JS shipped...(AI_HYDRA_LEO_MISSING_COMMA)
packages/uploadthing/CHANGELOG.md (1)
26-30: Migration required for URL field deprecationThe deprecation of
urlandappUrlfields requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrlinstead- Review and update documentation examples
- Consider adding migration notes to your changelog
The change is well-supported with deprecation warnings and backward compatibility, allowing for a gradual transition to the new field.
✅ Verification successful
Deprecation is properly handled with clear migration path
The codebase already includes:
- Deprecation warnings for both
urlandappUrlfields- The new
ufsUrlfield alongside deprecated fields for backward compatibility- Clear messaging that these fields will be removed in v9
No immediate action required as the deprecation is being handled gracefully with proper warnings and migration guidance.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find usages of deprecated url and appUrl fields # Test: Search for field usage in code. Expect: Instances where these fields are used. echo "Searching for deprecated field usages..." rg -A 2 'url: |appUrl: ' || echo "No direct field usage found" echo "Searching for field access..." rg -A 2 '\.url|\.appUrl' || echo "No field access found"Length of output: 60146
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
79b64a4 to
c351c56
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/shared/CHANGELOG.md (3)
3-10: Consider enhancing the documentation for version 7.1.6While the changelog entry follows good practices, it would be more helpful to users if it included:
- The impact of allowing deeply nested objects in JsonArray
- Whether there are any breaking changes
- Migration steps if necessary
181-182: Fix minor formatting issuesThere are a few formatting inconsistencies:
- Remove extra spaces in "...flexibility to make changes to the API without needing..."
- Add a missing comma after "bundle" in "...from client bundle resulting in..."
-This change improves our flexibility to make changes to the API without needing +This change improves our flexibility to make changes to the API without needing -from client bundle resulting in up to 15kB less JS shipped +from client bundle, resulting in up to 15kB less JS shippedAlso applies to: 265-265
🧰 Tools
🪛 LanguageTool
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
214-214: Use proper markdown link syntax for URLsConvert bare URLs to proper markdown links for better readability:
-See upstream issue: https://github.com/Effect-TS/effect/issues/3057 +See upstream issue: [Effect-TS/effect#3057](https://github.com/Effect-TS/effect/issues/3057) -https://docs.uploadthing.com/getting-started/svelte +[https://docs.uploadthing.com/getting-started/svelte](https://docs.uploadthing.com/getting-started/svelte)Also applies to: 343-343
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (1)
309-310: Fix the bare URL in the documentation.The URL should be wrapped in angle brackets or made into a proper markdown link.
-https://docs.uploadthing.com/getting-started/svelte +<https://docs.uploadthing.com/getting-started/svelte>🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/react/CHANGELOG.md (1)
264-264: Fix the bare URL in the documentation.The URL should be wrapped in angle brackets or made into a proper markdown link.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +<https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/good-tables-jump.md
- .changeset/curvy-rings-own.md
- .changeset/nice-penguins-grow.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (32)
- packages/vue/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/nuxt/package.json
- examples/with-serveractions/package.json
- packages/shared/package.json
- examples/backend-adapters/server/package.json
- examples/backend-adapters/client-react/package.json
- packages/solid/package.json
- examples/minimal-expo/package.json
- examples/with-react-image-crop/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-tailwindcss/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- examples/backend-adapters/client-vue/package.json
- packages/uploadthing/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-astro-react/package.json
- packages/svelte/package.json
- examples/backend-adapters/package.json
- examples/minimal-sveltekit/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-clerk-react-router/package.json
- examples/minimal-nuxt/package.json
- examples/profile-picture/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-appdir/package.json
- examples/minimal-tanstack-start/package.json
- packages/react/package.json
- packages/expo/package.json
- examples/with-drizzle-appdir/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/solid/CHANGELOG.md
[uncategorized] ~169-~169: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
337-337: null
Bare URL used
(MD034, no-bare-urls)
511-511: null
Bare URL used
(MD034, no-bare-urls)
589-589: null
Bare URL used
(MD034, no-bare-urls)
736-736: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (12)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! Version bump and dependency update are consistent.The changelog entry correctly documents:
- Patch version bump to 7.1.6
- Updated dependency on @uploadthing/vue to version 7.2.0
This aligns with the PR objectives.
Line range hint
1-241: LGTM! Changelog structure is well-maintained.The changelog follows consistent formatting with proper version entries, change types, PR references, commit links, and contributor credits.
packages/shared/CHANGELOG.md (1)
Line range hint
1-599: LGTM! The changelog is well-maintainedThe changelog follows good practices:
- Clear version numbering following semver
- Proper categorization of changes (Major/Minor/Patch)
- Links to PRs and commits
- Credits to contributors
- Clear descriptions of changes
🧰 Tools
🪛 LanguageTool
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove@effect/schemafrom client bundle resulting in up to 15kB less JS shipped...(AI_HYDRA_LEO_MISSING_COMMA)
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
343-343: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (4)
7-10: LGTM: Custom fetch override feature added.The addition of a custom fetch override feature is well-documented and properly credited to @juliusmarminge.
14-19: LGTM: Improved error handling in utapi.The patch fixes an important issue where errors were being silently ignored when they shouldn't have been. This improves error visibility and debugging.
32-34: LGTM: Dependency update.The dependency update to @uploadthing/[email protected] is properly documented.
26-30: Consider adding migration guide for URL field deprecation.The deprecation of
urlandappUrlfields in favor of the newufsUrlfield may require users to update their code. Consider adding a migration guide to help users transition smoothly.Let's check for any documentation or migration guides:
packages/expo/CHANGELOG.md (1)
3-18: LGTM! The changelog entry for version 7.2.0 is well documented.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/[email protected]
packages/vue/CHANGELOG.md (1)
3-17: LGTM! The changelog entry for version 7.2.0 is consistent with other packages.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/[email protected]
packages/svelte/CHANGELOG.md (1)
3-17: LGTM! The changelog entry for version 7.2.0 maintains consistency.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/[email protected]
packages/solid/CHANGELOG.md (1)
3-17: LGTM! The changelog entry for version 7.2.0 follows the established pattern.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/[email protected]
packages/react/CHANGELOG.md (1)
3-17: LGTM! The changelog entry for version 7.2.0 completes the consistent updates across all packages.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/[email protected]
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
c0032ab to
ea46243
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/shared/CHANGELOG.md (1)
167-169: Fix typos in changelog entries.There are a few typos in the changelog that should be corrected:
- "hasve" should be "have"
- Remove extra space between sentences
- Multi Part Uplaods hasve been abstracted away and files are now uploaded as a + Multi Part Uploads have been abstracted away and files are now uploaded as a single stream to UploadThing, reducing the manual steps required to upload files and improves performance. - Polling has been removed in favor of a streaming upload process with instant - feedback + Polling has been removed in favor of a streaming upload process with instant feedbackAlso applies to: 171-172
packages/nuxt/CHANGELOG.md (1)
Line range hint
1-241: Verify changelog format consistency.The changelog follows the Changesets format but some entries could be improved:
- Version 7.1.0 has detailed examples that might be better suited for documentation
- Some entries have inconsistent spacing between sections
Consider standardizing the changelog format:
- Keep entries concise and focused on changes
- Move detailed examples to documentation
- Maintain consistent spacing between sections
packages/react/CHANGELOG.md (1)
3-16: Consider enhancing the documentation for the custom fetch override feature.The changelog entry for version 7.2.0 could be more helpful by including a brief example of how to use the new custom fetch override feature. This would make it easier for users to understand and implement the change.
Consider adding usage examples like:
### Minor Changes - [#1099](https://github.com/pingdotgg/uploadthing/pull/1099) [`36b0df6`](https://github.com/pingdotgg/uploadthing/commit/36b0df6c3b94358d1a12112d661bc561256cc98e) Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - feat: allow custom fetch override + + Example usage: + ```ts + useUploadThing("endpoint", { + customFetch: async (url, options) => { + // Your custom fetch logic here + return fetch(url, options); + } + }); + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/curvy-rings-own.md
- .changeset/good-tables-jump.md
- .changeset/nice-penguins-grow.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (36)
- packages/nuxt/package.json
- packages/shared/package.json
- examples/with-serveractions/package.json
- packages/solid/package.json
- packages/vue/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/minimal-tanstack-start/package.json
- examples/backend-adapters/server/package.json
- packages/uploadthing/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-sveltekit/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-novel/package.json
- examples/minimal-appdir/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-react-image-crop/package.json
- examples/with-drizzle-appdir/package.json
- packages/expo/package.json
- examples/with-clerk-appdir/package.json
- examples/profile-picture/package.json
- examples/with-clerk-remix/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-nuxt/package.json
- examples/backend-adapters/client-react/package.json
- packages/expo/CHANGELOG.md
- packages/svelte/package.json
- packages/svelte/CHANGELOG.md
- examples/with-clerk-react-router/package.json
- packages/react/package.json
- packages/solid/CHANGELOG.md
- packages/uploadthing/CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (6)
packages/vue/CHANGELOG.md (3)
3-16: LGTM! Version bump and changelog entry are consistent with PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor feature addition allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependency on @uploadthing/[email protected]
This aligns with the PR objectives which indicate a coordinated release across multiple packages.
22-28: LGTM! Previous version entry provides good context.The changelog entry for version 7.1.5 properly documents the relaxation of peer dependency requirements, which helps understand the package's evolution.
Line range hint
1-286: LGTM! Changelog format follows best practices.The changelog maintains consistent formatting throughout with:
- Clear version headers
- Proper categorization of changes (Minor/Patch)
- Complete reference information (PRs, commits, contributors)
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md (1)
3-10: LGTM! The changelog entry follows the Keep a Changelog format.The new version 7.1.6 is properly documented with:
- Clear reference to PR fix: allow nested objects in
JsonArraytype #1127- Descriptive commit hash
- Credit to contributor
- Concise description of the fix
packages/nuxt/CHANGELOG.md (1)
3-9: LGTM! Version bump aligns with PR objectives.The dependency update to
@uploadthing/[email protected]is consistent with the PR objectives, which mention version updates across multiple packages.packages/react/CHANGELOG.md (1)
Line range hint
1-540: Well-structured changelog format.The changelog follows best practices with:
- Clear version numbering
- Proper categorization of changes (Minor, Patch)
- Consistent linking to PRs and commits
- Credit to contributors
- Dependency updates tracking
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
2cd96f9 to
d05e7f7
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/react/CHANGELOG.md (1)
264-264: Convert bare URL to markdown link format.The bare URL should be converted to a proper markdown link for better readability and to comply with markdown best practices.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[Example](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
264-264: Bare URL used
null(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (3)
73-81: Consider updating the documentation for custom identifiers feature.The changelog could benefit from cross-referencing the custom identifiers feature introduced in version 7.1.0 with the implementation in version 6.3.0, as they appear to be related features. This would help users understand the feature evolution.
Also applies to: 412-415
167-172: Fix typo in changelog entry.There's a typo in the changelog entry for version 7.0.0:
-Multi Part Uplaods hasve been abstracted away +Multi Part Uploads have been abstracted away
179-183: Improve clarity in version 7.0.0 changelog entry.The explanation of the API version handling could be clearer. Consider restructuring for better readability:
-Previously the SDK version was just sent in the header which made it cumbersome to make large changes on the API without risking breaking older versions. This change improves our flexibility to make changes to the API without needing to do a major bump on the SDK. +Previously, the SDK version was only sent in the header, making it difficult to implement significant API changes without potentially breaking older versions. This change improves our ability to evolve the API independently of the SDK versioning.🧰 Tools
🪛 LanguageTool
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
packages/uploadthing/CHANGELOG.md (1)
21-24: Consider adding implementation examples for the custom fetch override feature.The changelog entry for the custom fetch override feature could benefit from including usage examples to help users understand how to implement this new functionality.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md(0 hunks).changeset/fair-rockets-beg.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/good-tables-jump.md
- .changeset/curvy-rings-own.md
- .changeset/fair-rockets-beg.md
- .changeset/nice-penguins-grow.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (34)
- packages/shared/package.json
- packages/vue/package.json
- examples/backend-adapters/server/package.json
- packages/nuxt/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-serveractions/package.json
- packages/solid/package.json
- examples/minimal-appdir/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/profile-picture/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-solidstart/package.json
- examples/with-novel/package.json
- examples/with-drizzle-appdir/package.json
- packages/uploadthing/package.json
- examples/with-tailwindcss/package.json
- packages/expo/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-expo/package.json
- examples/with-react-image-crop/package.json
- packages/svelte/package.json
- examples/backend-adapters/client-vue/package.json
- packages/expo/CHANGELOG.md
- examples/backend-adapters/package.json
- examples/with-clerk-react-router/package.json
- examples/with-clerk-appdir/package.json
- packages/solid/CHANGELOG.md
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 markdownlint-cli2 (0.17.2)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/svelte/CHANGELOG.md (1)
3-16: LGTM! Version entry follows changelog conventions.The new version entry is well-structured with:
- Proper semantic versioning
- Clear feature description
- Correct attribution
- Linked PR and commit references
packages/react/CHANGELOG.md (2)
3-16: LGTM! Clear and well-structured changelog entry.The latest version entry (7.2.0) is well documented with:
- Clear version number
- Proper categorization of changes (Minor/Patch)
- Link to the related PR (feat: add custom fetch override #1099)
- Credit to the contributor (@juliusmarminge)
- Clear description of the feature
Line range hint
1-571: LGTM! Well-maintained changelog.The changelog follows good practices:
- Consistent version numbering
- Clear categorization of changes (Major/Minor/Patch)
- Links to PRs and commits
- Credit to contributors
- Detailed descriptions of changes
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
264-264: Bare URL used
null(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (1)
3-10: LGTM! Clear documentation of the latest changes.The changelog entry for version 7.1.6 properly documents the fix for handling deeply nested objects when using JsonArray, with appropriate reference to PR #1127.
packages/vue/CHANGELOG.md (3)
3-16: LGTM! Well-structured changelog entry.The new version entry follows proper changelog conventions with clear categorization, proper references, and complete dependency information.
Line range hint
17-286: LGTM! Historical entries maintain consistency.The historical changelog entries follow a consistent format and provide comprehensive version history with proper references and credits.
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
Line range hint
1-286: LGTM! Changelog follows best practices.The changelog maintains high documentation standards with proper categorization, consistent formatting, and complete metadata throughout its history.
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! Version entry follows semver correctly.The patch version bump and dependency update to @uploadthing/[email protected] are consistent with the PR objectives.
Line range hint
15-241: Excellent changelog maintenance!The changelog demonstrates consistent high quality:
- Clear semantic versioning
- Detailed descriptions with proper PR/commit links
- Consistent formatting
- Proper contributor attribution
packages/uploadthing/CHANGELOG.md (1)
40-44: Migration required for URL field deprecation.The deprecation of
urlandappUrlfields requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrlinstead- Review and update documentation examples
- Consider adding migration notes to your changelog
The change is well-supported with deprecation warnings and backward compatibility, allowing for a gradual transition to the new field.
Run the following script to find usages of the deprecated fields:
✅ Verification successful
URL field deprecation is properly handled with backward compatibility
The deprecation of
urlandappUrlfields is well-managed with:
- Runtime deprecation warnings when accessing old fields
- Backward compatibility maintained while providing the new
ufsUrlfield- Test coverage updated to verify both old and new field behavior
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find usages of deprecated url and appUrl fields # Test: Search for field usage in code. Expect: Instances where these fields are used. echo "Searching for deprecated field usages..." rg -A 2 'url: |appUrl: ' || echo "No direct field usage found" echo "Searching for field access..." rg -A 2 '\.url|\.appUrl' || echo "No field access found"Length of output: 60146
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
4f11470 to
4fa4d59
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
218934c to
ce90b04
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
packages/uploadthing/CHANGELOG.md (1)
40-44: 🛠️ Refactor suggestionMigration guidance needed for URL field deprecation.
The deprecation of
urlandappUrlfields in favor ofufsUrlis a significant change that may impact existing implementations. Consider adding migration steps and a deprecation timeline to help users transition smoothly.Note: A similar comment was made in a previous review. The deprecation requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrlinstead- Review and update documentation examples
- Consider adding migration notes to your changelog
🧹 Nitpick comments (3)
packages/react/CHANGELOG.md (2)
264-264: Format bare URL as markdown link.The bare URL should be formatted as a markdown link for better readability and consistency.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[Example Implementation](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
264-264: Bare URL used
null(MD034, no-bare-urls)
7-10: Add implementation examples for the custom fetch override feature.The changelog entry would be more helpful if it included examples of how to use the new custom fetch override feature.
Consider adding implementation examples like:
// Example usage of custom fetch override const { useUploadThing } = generateReactHelpers<OurFileRouter>(); function MyComponent() { const { startUpload } = useUploadThing("endpoint", { customFetch: async (url, options) => { // Custom fetch implementation return fetch(url, { ...options, headers: { ...options.headers, 'Custom-Header': 'value' } }); } }); }packages/uploadthing/CHANGELOG.md (1)
21-24: Consider enhancing documentation for custom fetch override feature.The custom fetch override feature is mentioned but lacks implementation details. Consider adding a code example to demonstrate its usage, similar to how the tailwind plugin is documented.
Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - feat: allow custom fetch override + + Example usage: + ```ts + // Configure custom fetch override + { + customFetch: async (url, options) => { + // Your custom fetch implementation + return fetch(url, { + ...options, + // Custom options + }); + } + } + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md(0 hunks).changeset/fair-rockets-beg.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/curvy-rings-own.md
- .changeset/fair-rockets-beg.md
- .changeset/purple-shrimps-chew.md
- .changeset/good-tables-jump.md
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (34)
- packages/shared/package.json
- packages/nuxt/package.json
- examples/with-serveractions/package.json
- examples/backend-adapters/server/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-expo/package.json
- packages/solid/package.json
- examples/minimal-appdir/package.json
- packages/uploadthing/package.json
- packages/expo/CHANGELOG.md
- packages/svelte/package.json
- packages/vue/package.json
- examples/with-drizzle-appdir/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/minimal-sveltekit/package.json
- examples/with-novel/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/backend-adapters/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-solidstart/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-tanstack-start/package.json
- examples/minimal-pagedir/package.json
- examples/backend-adapters/client-react/package.json
- examples/profile-picture/package.json
- examples/with-clerk-react-router/package.json
- packages/react/package.json
- packages/solid/CHANGELOG.md
- examples/with-clerk-remix/package.json
- packages/expo/package.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~184-~184: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~295-~295: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~503-~503: You might be missing the article “the” here.
Context: ... UploadButton progress text going under progress bar - Updated dependencies [[`f0a4ae...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/svelte/CHANGELOG.md
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (6)
packages/nuxt/CHANGELOG.md (1)
3-9: LGTM! Version and dependency updates are properly documented.The changelog correctly documents:
- Version bump to 7.1.6
- Updated dependency @uploadthing/vue to version 7.2.0
packages/vue/CHANGELOG.md (1)
3-16: LGTM! Version, feature, and dependency updates are properly documented.The changelog correctly documents:
- Version bump to 7.2.0
- New feature: custom fetch override
- Updated dependency @uploadthing/shared to version 7.1.6
packages/svelte/CHANGELOG.md (2)
3-16: LGTM! Version entry follows changelog best practices.The new version entry is well-structured with:
- Clear feature description
- Proper contributor attribution
- Accurate dependency updates
Line range hint
22-315: LGTM! Previous version entries maintain consistent documentation.The changelog history is well-maintained with:
- Consistent formatting
- Clear documentation of changes
- Proper references to PRs and commits
🧰 Tools
🪛 LanguageTool
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/shared/CHANGELOG.md (2)
3-10: LGTM! Latest version entry is well documented.The changelog entry for version 7.1.6 properly documents:
- The PR reference (fix: allow nested objects in
JsonArraytype #1127)- The commit hash
- The contributor acknowledgment
- A clear description of the patch change
Line range hint
1-458: LGTM! Changelog is well-maintained and follows best practices.The changelog demonstrates:
- Consistent version numbering
- Clear categorization of changes (Minor/Patch)
- Proper documentation of breaking changes
- Complete reference tracking (PRs, commits, contributors)
🧰 Tools
🪛 LanguageTool
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
github-actions
bot
force-pushed
the
changeset-release/main
branch
2 times, most recently
from
3a53222 to
87dde21
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/svelte/CHANGELOG.md (1)
309-310: Fix the bare URL in documentation.The documentation URL should be wrapped in angle brackets or formatted as a proper markdown link.
-https://docs.uploadthing.com/getting-started/svelte +<https://docs.uploadthing.com/getting-started/svelte>🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
310-310: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md(0 hunks).changeset/fair-rockets-beg.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/curvy-rings-own.md
- .changeset/good-tables-jump.md
- .changeset/nice-penguins-grow.md
- .changeset/fair-rockets-beg.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (34)
- examples/backend-adapters/server/package.json
- packages/nuxt/package.json
- examples/with-serveractions/package.json
- examples/minimal-sveltekit/package.json
- examples/with-clerk-react-router/package.json
- examples/minimal-nuxt/package.json
- packages/solid/package.json
- examples/with-drizzle-appdir/package.json
- packages/expo/package.json
- packages/vue/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- packages/shared/package.json
- examples/with-react-image-crop/package.json
- examples/with-clerk-appdir/package.json
- examples/backend-adapters/client-react/package.json
- packages/uploadthing/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-expo/package.json
- examples/minimal-appdir/package.json
- packages/expo/CHANGELOG.md
- examples/backend-adapters/client-vue/package.json
- packages/svelte/package.json
- examples/backend-adapters/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-solidstart/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-astro-react/package.json
- examples/profile-picture/package.json
- examples/with-drizzle-pagesdir/package.json
- packages/react/package.json
- examples/minimal-tanstack-start/package.json
- packages/solid/CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~184-~184: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~295-~295: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/shared/CHANGELOG.md
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/vue/CHANGELOG.md
[uncategorized] ~174-~174: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~249-~249: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 markdownlint-cli2 (0.17.2)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: Bare URL used
null
(MD034, no-bare-urls)
343-343: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (11)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! The new version entry is correctly formatted and aligns with PR objectives.The changelog entry for version 7.1.6 properly documents:
- The patch version increment
- The dependency update to @uploadthing/[email protected]
- The correct commit reference
Line range hint
1-241: LGTM! The changelog follows best practices.The changelog maintains:
- Clear version sections with semantic versioning
- Proper categorization of changes (Minor/Patch)
- Consistent formatting with PR links and contributor credits
- Detailed descriptions of significant changes
packages/svelte/CHANGELOG.md (1)
3-16: LGTM! Version 7.2.0 changes are well documented.The changelog entry for version 7.2.0 properly documents:
- The minor change introducing custom fetch override feature
- The dependency update to @uploadthing/[email protected]
- Proper attribution to contributor @juliusmarminge
- Correct PR and commit references
This aligns with the PR objectives which mention the custom fetch override feature being added across multiple packages.
packages/vue/CHANGELOG.md (1)
3-16: LGTM!The changelog entry for version 7.2.0 is well-structured and properly documents both the minor change (custom fetch override) and the patch change (dependency update).
packages/shared/CHANGELOG.md (1)
3-10: LGTM!The changelog entry for version 7.1.6 is well-structured and properly documents the patch change for allowing deeply nested objects when using JsonArray.
packages/react/CHANGELOG.md (1)
3-16: LGTM!The changelog entry for version 7.2.0 is well-structured and properly documents both the minor change (custom fetch override) and the patch change (dependency update).
packages/uploadthing/CHANGELOG.md (5)
7-19: New Tailwind v4 CSS plugin integrationThe addition of a Tailwind v4 CSS plugin provides a cleaner way to import styles directly into CSS files. The implementation looks good with clear usage examples.
Example usage:
@import "tailwindcss"; @import "uploadthing/tw/v4"; @source "../node_modules/@uploadthing/react/dist"; /** <-- depends on your project structure */
28-34: Improved error handling in utapiThe patch enhances error handling by ensuring errors are no longer silently ignored when they shouldn't be. This is a good improvement for debugging and reliability.
The change helps developers identify and fix issues more easily by making error conditions more visible.
35-39: Support for deeply nested objects in JsonArrayThe addition of support for deeply nested objects when using JsonArray improves flexibility in handling complex data structures.
This enhancement allows for more sophisticated data modeling while maintaining compatibility.
46-48: Dependency updateThe dependency
@uploadthing/sharedhas been updated to version 7.1.6.This update ensures compatibility with the latest shared utilities.
40-44: Migration required for URL field deprecationA new
ufsUrlfield has been introduced with formathttps://APP_ID.ufs.sh/f/FILE_KEYwhileurlandappUrlfields are being deprecated. This change requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrlinstead- Review and update documentation examples
- Consider adding migration notes to your changelog
The change is well-supported with deprecation warnings and backward compatibility, allowing for a gradual transition to the new field.
✅ Verification successful
URL field deprecation is properly implemented with clear migration path
The deprecation of
urlandappUrlfields is well-implemented with:
- Clear deprecation warnings pointing to the new
ufsUrlfield- Backward compatibility maintained until version 9
- Proper documentation in the changelog
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find usages of deprecated url and appUrl fields # Test: Search for field usage in code. Expect: Instances where these fields are used. echo "Searching for deprecated field usages..." rg -A 2 'url: |appUrl: ' || echo "No direct field usage found" echo "Searching for field access..." rg -A 2 '\.url|\.appUrl' || echo "No field access found"Length of output: 60146
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
de4834b to
d94a9b0
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/uploadthing/CHANGELOG.md (3)
26-32: Patch Change: Improved Error Handling in utapi
The fix for improved error handling inutapiis described succinctly. For added clarity in future releases, consider specifying which error cases are now handled or what conditions prevented errors from being silently ignored.
40-44: Patch Change: Introduction ofufsUrland Deprecation ofurl&appUrl
This entry clearly documents the addition of the newufsUrlfield along with its expected URL format and the deprecation of theurlandappUrlfields. It would be beneficial to ensure that migration guides or deprecation notices are updated in the documentation to help users transition smoothly.
1-2126: Markdown Styling: Bare URLs in Changelog
The static analysis hints indicate that there are occurrences of bare URLs (e.g., around lines 351, 525, 603, and 750) which may trigger MD034 (no-bare-urls) warnings. Although these may not be directly related to the new changes, it is recommended to review the affected lines and, where possible, wrap URLs in angle brackets or convert them to proper Markdown link syntax to enhance readability and adherence to style guidelines.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
351-351: Bare URL used
null(MD034, no-bare-urls)
525-525: Bare URL used
null(MD034, no-bare-urls)
603-603: Bare URL used
null(MD034, no-bare-urls)
750-750: Bare URL used
null(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (2)
214-214: Markdown Formatting – Bare URL.
A bare URL is present here. For improved markdown styling and to satisfy linting rules (MD034), consider wrapping this URL in proper link syntax.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
214-214: Bare URL used
null(MD034, no-bare-urls)
342-343: Documentation Link Format (SvelteKit).
A bare URL is used here. For better markdown compliance, please consider converting it into a proper markdown link.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
343-343: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md(0 hunks).changeset/fair-rockets-beg.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/nice-penguins-grow.md
- .changeset/curvy-rings-own.md
- .changeset/fair-rockets-beg.md
- .changeset/good-tables-jump.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (34)
- packages/vue/package.json
- packages/solid/package.json
- packages/shared/package.json
- packages/uploadthing/package.json
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- packages/expo/package.json
- examples/with-tailwindcss/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- packages/expo/CHANGELOG.md
- examples/with-drizzle-pagesdir/package.json
- examples/with-novel/package.json
- examples/profile-picture/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/server/package.json
- examples/backend-adapters/package.json
- examples/with-drizzle-appdir/package.json
- examples/minimal-appdir/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-sveltekit/package.json
- examples/backend-adapters/client-react/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-tanstack-start/package.json
- packages/react/package.json
- packages/solid/CHANGELOG.md
- examples/with-clerk-appdir/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-clerk-remix/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-nuxt/package.json
- examples/with-react-image-crop/package.json
- examples/with-clerk-react-router/package.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: Bare URL used
null
(MD034, no-bare-urls)
343-343: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (94)
packages/uploadthing/CHANGELOG.md (5)
3-3: Version Header for 7.5.0 Added
The new release header (## 7.5.0) is clearly introduced to mark the latest version. This helps readers quickly identify the changes included in this release.
5-11: Minor Change: Tailwind v4 CSS Plugin Entry
The changelog entry for the new Tailwind v4 CSS plugin is well documented. It includes proper attribution, a commit reference, and a clear usage example that explains how to import the new CSS plugin. Please ensure that the usage paths remain accurate with respect to your project structure.
21-25: Minor Change: Custom Fetch Override Feature
The entry for the custom fetch override is concise and clear. It references the appropriate pull request and commit hash along with proper acknowledgement. This entry neatly conveys the new capability without ambiguity.
35-39: Patch Change: Support for Deeply Nested Objects in JsonArray
The changelog note for allowing deeply nested objects when usingJsonArrayis well stated. This update is important for handling complex nested data structures and is clearly conveyed in this entry.
46-49: Dependency Update: @uploadthing/shared Version Bump
The dependency update to@uploadthing/[email protected]is clearly noted and aligns with the other package updates. This entry is straightforward and meets the documentation standards for dependency changes.packages/nuxt/CHANGELOG.md (5)
3-10: New Version Entry for 7.1.6 and Dependency Update
A new changelog entry for version 7.1.6 is added, which clearly indicates a patch change updating the dependency to@uploadthing/[email protected]. This update looks correct and aligns with the release objectives.
15-18: Patch Change for 7.1.5 – Peer Dependency Relaxation
This segment documents a patch change (pull request [#1108]) that relaxes peer dependency requirements between UploadThing packages. The description is concise and credits the contributor appropriately.
20-22: Dependency Version Update in 7.1.5
This change updates the dependency for@uploadthing/vueto version 7.1.5 in the 7.1.5 section. Ensure that the version progression is consistent with the other package changelogs.
28-30: Dependency Update for Version 7.1.4
The changelog entry here correctly reflects the updated dependency for@uploadthing/vueto version 7.1.4. The format is consistent with previous entries.
43-47: Fix for Module Options Not Honored in 7.1.2
This patch change explicitly documents a fix (pull request [#1056]) addressing module options not honored due to static analysis. The note is clear and highlights the improvement in functionality.packages/vue/CHANGELOG.md (6)
3-11: Version 7.2.0 – Custom Fetch Override Introduced
A new entry for version 7.2.0 is added with a minor change that introduces a custom fetch override. The commit reference and contributor citation are correctly provided.
12-17: Patch Change – Dependency Update for Shared Module
The patch change updates the dependency@uploadthing/sharedto version 7.1.6. This is clear and matches the expected release changes.
22-26: Version 7.1.5 – Peer Dependency Relaxation
This segment for version 7.1.5 documents the relaxed peer dependency requirements. The message is clear, and the commit reference is provided.
27-30: Dependency Downgrade for Version 7.1.5
Here the dependency@uploadthing/sharedis updated to version 7.1.5, which is consistent with the changes shown in the other package files.
31-39: Version 7.1.4 – Tidy-Up and Dependency Update
This patch change tidies up the peer dependency ranges and updates the dependency to@uploadthing/[email protected]. The change is precise and well documented.
44-51: Version 7.1.3 and 7.1.2 – Dependency Updates
The subsequent entries update the dependency versions for older versions (7.1.3 and 7.1.2). The changes are straightforward and ensure historical consistency.packages/svelte/CHANGELOG.md (6)
3-11: Version 7.2.0 – Custom Fetch Override Feature
A new changelog entry for version 7.2.0 is present with a minor change that adds the custom fetch override feature. The commit reference and credit to the contributor are properly included.
12-17: Patch Change – Shared Dependency Bump
The dependency@uploadthing/sharedis updated to version 7.1.6 under the patch changes section. This update is clear and aligns with the overall ecosystem update.
22-26: Version 7.1.5 – Peer Dependency Relaxation
This segment captures the patch change for version 7.1.5 that relaxes peer dependency requirements, with the proper commit and contributor citation.
27-30: Shared Dependency Update for Version 7.1.5
Consistently, the dependency is further updated to@uploadthing/[email protected]in this segment.
31-38: Version 7.1.4 – Dependency Update
This patch section updates the dependency to@uploadthing/[email protected]for version 7.1.4, maintaining consistency with other changelog files.
39-46: Versions 7.1.3 and 7.1.2 – Dependency Alignments
The dependency updates for versions 7.1.3 (@uploadthing/[email protected]) and 7.1.2 (@uploadthing/[email protected]) are clear, leaving no ambiguity.packages/react/CHANGELOG.md (5)
3-11: Version 7.2.0 – Introduction of Custom Fetch Override
The entry for version 7.2.0 documents a minor change to allow a custom fetch override. The commit reference and contributor credit are accurate.
12-17: Patch Change – Shared Dependency Upgrade
The dependency@uploadthing/sharedis updated to 7.1.6 in this patch change section, aligning with updates in other packages.
18-26: Version 7.1.5 – Peer Dependency Adjustment
This section captures the peer dependency relaxation and subsequent dependency update (@uploadthing/[email protected]) for version 7.1.5. The information is concise and clear.
31-39: Version 7.1.4 – Tidying Peer Dependency Ranges
The patch changes for version 7.1.4 include a tidy-up of peer dependency ranges and update the shared dependency to 7.1.4. Both actions are clearly documented.
44-51: Versions 7.1.3 and 7.1.2 – Consistent Dependency Updates
The dependency updates in the sections for versions 7.1.3 (@uploadthing/[email protected]) and 7.1.2 (@uploadthing/[email protected]) are precise and maintain a coherent release history across the ecosystem.packages/shared/CHANGELOG.md (67)
3-10: Version 7.1.6 Entry Clarity.
The new “7.1.6” section clearly documents the patch change (allowing deeply nested objects for JsonArray) and properly credits the contributor.
16-24: Version 7.1.5 Documentation.
The “7.1.5” patch changes section explains the chore change and updated dependency clearly. Please double-check that the dependency version update is aligned with the other package changelogs.
29-37: Version 7.1.4 Patch Updates.
The entry about tidying up peer dependency ranges is concise and clear. Ensure that any dependency adjustments elsewhere remain consistent with this note.
42-45: Version 7.1.3 – Internal Dependency Bump.
The changelog entry for bumping internal effect dependencies is straightforward and well documented.
51-60: Version 7.1.2 – Multiple Fixes.
This section documents both the internal effect version bump and the fix for constructing RFC6266-compliant content-disposition headers. The details are clear and complete.
65-67: Version 7.1.1 Dependency Update.
The updated dependency (mime-types version update) is recorded properly.
73-81: Version 7.1.0 Minor Change: Route Endpoint Support.
The new feature supporting a custom route endpoint is detailed and includes proper contributor credit.
107-109: Version 7.1.0 – Internal Effect Dependency Bump.
The additional patch change noting a bump in internal effect dependencies is clear and concise.
124-134: Version 7.0.3 – Package Removal & Vite Fix.
The patch changes in this section (removing the internal dropzone package and addressing Vite monorepo issues) are clearly documented with proper commit references.
135-139: Version 7.0.3 – Mime Type Preference Fix.
The note about preferring browser-recognized mime types over file extension lookup is straightforward and well noted.
145-148: Version 7.0.2 – Correcting Variable Names.
The correction to variable names for accuracy is clearly indicated.
154-156: Version 7.0.1 – Dependency Update.
The updated dependency (mime-types update) is documented effectively in this patch section.
162-172: Version 7.0.0 – Major Change (Multipart Uploads Part I).
The section introduces a major feature: multipart uploads using an ingest server. The details clearly explain the benefits such as reduced upload steps and improved performance.
174-183: Version 7.0.0 – Major Change (API Domain Update).
The follow‐up entry on updating paths to the new API domain and enhancing API flexibility is thorough and well articulated.🧰 Tools
🪛 LanguageTool
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
189-192: Version 6.7.9 – API Path Update for Rewrites.
The change to update API paths to skip rewrites is documented clearly, ensuring proper tracking of internal adjustments.
194-198: Version 6.7.9 – Fix for Number Serialization.
This entry addresses the issue of non‑serializable numbers in router configurations. The description is concise and precise.
200-203: Version 6.7.8 – Effect/Encoding Refactor.
The refactor to useeffect/Encodingover Node.js Buffer is clearly noted and appears well considered.
209-213: Version 6.7.8 – Bumping Effect Versions.
Updating effect versions to fix Cloudflare Workers support is clearly documented.
220-223: Version 6.7.7 – Pinning Effect Versions.
The update to pin effect versions is clearly recorded with an appropriate commit reference and contributor credit.
229-233: Version 6.7.6 – Client Bundle Optimization.
The refactor usingeffect/Microto reduce the browser bundle size is well detailed and highlights the achieved improvements.
245-247: Version 6.7.5 – Import Utility Note.
The note detailing that importing utilities should not bloat the bundle (ifEffectisn’t otherwise used) is informative.
248-252: Version 6.7.5 – Mimic Dump for Catch-All Types.
Documenting the change to dump all matching mimetypes when using generic catch-all types is clear.
254-257: Version 6.7.5 – Header Parsing Refactor.
The refactor to support the breaking change in Node.js 20.13 for header parsing is clearly described.
263-266: Version 6.7.4 – Removing @effect/schema.
The removal of@effect/schemafrom the client bundle (resulting in a smaller JS payload) is well documented.
268-271: Version 6.7.4 – Enhancing Tree-shaking.
SettingsideEffects: falsefor better tree-shaking is explained clearly—this should help optimize the client bundle further.
277-280: Version 6.7.3 – isPollingResponse Fix.
The fix ensuring thatisPollingResponsecorrectly checks against response JSON is clearly described.
286-289: Version 6.7.2 – Handling FiberFailures.
The changelog entry indicating that FiberFailure errors are caught and squashed into the original error is precise and well documented.
291-294: Version 6.7.2 – Refactoring Upload Utilities.
The note about refactoring parts ofuploadFileand related utilities to the shared package is clear and supports better modularity.
300-303: Version 6.7.1 – Adding fast-check Peer Dependency.
The entry adding the missingfast-checkpeer dependency improves package stability and is clearly recorded.
305-308: Version 6.7.1 – Improved Error Logging.
Improved error logging for bad requests is well detailed and should lead to more robust troubleshooting.
310-313: Version 6.7.1 – Effect Import Update.
Updating “effect” and switching to alias imports is clearly documented and will aid in future maintenance.
319-321: Version 6.7.0 – Minor Change: logLevel Option.
The addition of thelogLeveloption to facilitate more verbose logging is a useful enhancement.
323-326: Version 6.7.0 – Vue and Nuxt Support.
Adding support for Vue and Nuxt markedly improves the package’s ecosystem support.
330-332: Version 6.7.0 – Forcing Dependency Bumps.
The forced dependency bumps provide clarity and consistency across versions.
338-340: Version 6.6.0 – SvelteKit Support.
Supporting SvelteKit is a timely feature addition; the associated commit and description are clear.
349-352: Version 6.5.0 – minFileCount Option.
Documenting the addition of theminFileCountoption in RouteConfig is clear and informative.
358-361: Version 6.4.0 – Verify Callback Data Signature.
The new feature to verify callback data signatures is clearly articulated and adds an important layer of security.
367-369: Version 6.3.4 – Workspace Protocol Fix.
Fixing the release issue related to theworkspace:protocol in published distributions is well noted.
375-378: Version 6.3.3 – API Consistency Improvement.
The changes to make the API more consistent with the available file data are straightforward.
380-383: Version 6.3.3 – Moving Internal Functions.
Refactoring some internally exported functions to the shared package enhances modularity.
389-392: Version 6.3.2 – Moving Types to Shared.
Moving some types to the shared package is a solid move to improve code reuse.
394-397: Version 6.3.2 – Enforcing Compatible Versions.
Enforcing a compatibleuploadthingversion for@uploadthing/reactis clearly described and should prevent mismatches.
403-406: Version 6.3.1 – CJS Client Splitting Fix.
The fix to force client splitting in .cjs output files is adequately described and important for bundling.
412-415: Version 6.3.0 – Custom Identifier Feature.
Adding the ability to provide custom identifiers when uploading files is a well-detailed new feature that enhances flexibility.
438-441: Version 6.3.0 – Presigned Post Uploads.
Introducing presigned post uploads for small files is clearly conveyed and should help reduce overhead.
445-447: Version 6.3.0 – Bundling Refactor.
The refactor of bundling (#579) is documented succinctly and appears beneficial.
453-458: Version 6.2.1 – Floating Error Messages.
Floating error messages to the client for UploadThingErrors along with the helpful docs link is excellent for debugging.
464-466: Version 6.2.0 – Cloudflare Workers Support.
The feature support for Cloudflare Workers is clearly highlighted; the commit details are appropriate.
472-475: Version 6.1.0 – logLevel Option Addition.
Introducing thelogLeveloption for more verbose logging is beneficial for debugging purposes.
477-481: Version 6.1.0 – getSignedURL and ACL Options.
The new API methods (utapi.getSignedURLand ACL configuration) are clearly documented in their added section.
487-490: Version 6.0.3 – Blob Fallback Implementation.
The fallback to blob filetype if allowed is well described and aids in handling file types gracefully.
496-499: Version 6.0.2 – Exponential Backoff Fix.
The fix addressing the exponential backoff infinite loop is critical and well documented.
505-508: Version 6.0.1 – Server Polling Timeout Fix.
The fix for serverdata polling timeout (returning 504) is described clearly and resolves a crucial issue.
514-517: Version 6.0.0 – Major Change: Multipart Uploads.
The major change introducing multipart uploads (with up to 2x speed improvement) is the highlight of this update and is well documented.
524-526: Version 5.2.7 – Dependency Update.
The dependency update for@uploadthing/mime-typesto 0.2.2 is clear and fits into the overall release narrative.
532-535: Version 5.2.6 – Zod Removal Changeset.
The changeset for removing Zod is clearly noted with appropriate thanks to the contributor.
541-544: Version 5.2.5 – Improved JSON Error Handling.
The improved error handling for invalid JSON parsing is well explained and important for robustness.
550-553: Version 5.2.4 – Remix Support Improvement.
Adding optional handling for import.meta.env calls improves support for Remix; the change is clearly documented.
559-562: Version 5.2.3 – Response Wrapping Robustness.
Wrapping response.json in a try-catch block is an effective way to handle unpredictable responses.
568-572: Version 5.2.2 – Safe Environment Variable Access.
The fix ensuring a safe access of process.env (with a fallback to import.meta.env) is clearly stated and addresses potential issues.
578-581: Version 5.2.1 – CJS Import Support.
Adding settings to support CommonJS imports is clearly documented and improves interoperability.
587-590: Version 5.2.0 – Serialization Functions Added.
The addition of serialization functions for UploadthingError enhances error reporting and is well documented.
596-599: Version 5.1.0 – Error Formatter Improvements.
The improvements to error formatting and the addition of theerrorFormatteroption are clearly outlined and valuable.
603-606: Version 5.1.0 – Type Declaration Fix.
The change to adjust internal types (to solve declaration emitting issues) strengthens the package’s type safety.
608-610: Version 5.1.0 – URL Function Order Swap.
Swapping the order of cases ingetUploadthingUrl()is clearly explained and likely improves reliability.
616-619: Version 5.0.1 – Simulated Callback Fix.
Adding the missingsizeproperty to the file object in simulated callbacks addresses a key issue and is correctly documented.
625-632: Version 5.0.0 – Shared Package Implementation.
Implementing a shared package for types and utilities (and updating dependencies accordingly) is a major consolidation that looks solid and consistent with the rest of the release notes.🧰 Tools
🪛 LanguageTool
[style] ~627-~627: Using many exclamation marks might seem excessive (in this case: 71 exclamation marks for a text that’s 21834 characters long)
Context: ...inge](https://github.com/juliusmarminge)! - implement a shared package that can...(EN_EXCESSIVE_EXCLAMATION)
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@uploadthing/[email protected]
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e,36b0df6]:@uploadthing/[email protected]
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e]:@uploadthing/[email protected]
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e]:@uploadthing/[email protected]
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e]:[email protected]
Minor Changes
#1138
ad75280Thanks @juliusmarminge! - feat: add
tailwind v4 css plugin
Usage:
#1099
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
#1125
aab8ab6Thanks @juliusmarminge! - fix: improve
error handling in utapi
sometimes errors got silently ignored when they shouldn't have
#1127
f08b20eThanks @juliusmarminge! - fix: allow
deeply nested objects when using JsonArray
#1128
e7ccec9Thanks @juliusmarminge! - chore: add new
ufsUrlfield withhttps://APP_ID.ufs.sh/f/FILE_KEYurl. deprecatedurland
appUrlfields.Updated dependencies
[
f08b20e]:@uploadthing/[email protected]
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e]:@uploadthing/[email protected]
Patch Changes
[
36b0df6]:@uploadthing/[email protected]
Patch Changes
f08b20eThanks @juliusmarminge! - fix: allow
deeply nested objects when using JsonArray
Summary by CodeRabbit
New Features
Bug Fixes
Chores