refactor: drop usage of util.inspect
#627
Conversation
🦋 Changeset detectedLatest commit: fb32b1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A new canary is available for testing. You can install this latest build in your project with: pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add [email protected] |
juliusmarminge
changed the title
util.inspect
| // fallback to JSON.stringify if inspect fails e.g. if runtime doesn't have util module | ||
| return JSON.stringify(arg, null, 4); | ||
| } | ||
| return JSON.stringify(arg, null, 4); |
There was a problem hiding this comment.
downside is if we attempt to log classes Response it will just output an empty object, but we don't do that anywhere today and according to my tests, logs looks good with JSON.stringify + we don't have to be concerned about runtime support:
|
A new canary is available for testing. You can install this latest build in your project with: pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add [email protected] |
Closes #626