test: describe network using only msw #711
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
this here fixes some incompatabilities with using happy-dom. Somewhere some serialization is failing which results in a new URL("[object Request]") which (obviously) fails. this patch seems to fix it
| } | ||
| this.logger.info("no mocked response received!"); | ||
| - return pureFetch(request).then((response) => { | ||
| + return pureFetch(resolvedInput, init).then((response) => { |
There was a problem hiding this comment.
Interesting. The request is created by taking init into account:
Can you tell me more about how you reproduce this issue? Would love to make a regression test out of it.
There was a problem hiding this comment.
Something with happy-dom when it's creating the url object for the request. seems like something doesn't get serialized as i debugged it was calling the URL constructor with the string [object Request] resulting in a Invalid URL error
There was a problem hiding this comment.
Looks much better now! Great job, @juliusmarminge. I've left a few comments on how you can improve MSW usage even further. Give those a read.
Co-authored-by: Artem Zakharchenko <[email protected]>
Co-authored-by: Artem Zakharchenko <[email protected]>
Co-authored-by: Artem Zakharchenko <[email protected]>
|
🚀 |
trying to get rid of our
mockExternalRequest(db)in favor of only using msw to describe all the external requests, no matter if the method accepts a fetch override or not.it's going.... well not so good 😓