Skip to content

Commit

Permalink
Update to latest pin cache (#381)
Browse files Browse the repository at this point in the history
* Update to latest PINCache

* Cartfile too

* Added CHANGELOG entry

* Now I remember why test wasn't first, build system relies on Carthage for updates

* Update test
  • Loading branch information
garrettmoon authored Jun 27, 2017
1 parent b7f4fba commit 2a8f62f
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
- [fixed] Fixes a deadlock with canceling processor tasks [#374](https://github.com/pinterest/PINRemoteImage/pull/374) [zachwaugh](https://github.com/zachwaugh)
- [fixed] Fixes a deadlock in the retry system. [garrettmoon](https://github.com/garrettmoon)
- [fixed] Fixes a threadsafety issue in accessing callbacks. [garrettmoon](https://github.com/garrettmoon)
- [new] PINRemoteImageManager now respects the request timout value of session configuration. [garrettmoon](https://github.com/garrettmoon)
- [new] PINRemoteImageManager now respects the request timeout value of session configuration. [garrettmoon](https://github.com/garrettmoon)
- [new] Updated to latest PINCache beta 5. [garrettmoon](https://github.com/garrettmoon)

## 3.0.0 Beta 10
- [new] Added support (in iOS 10) for skipping cancelation if the estimated amount of time to complete the download is less than the average time to first byte for a host. [#364](https://github.com/pinterest/PINRemoteImage/pull/364) [garrettmoon](https://github.com/garrettmoon)
Expand Down
2 changes: 1 addition & 1 deletion Cartfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
git "https://chromium.googlesource.com/webm/libwebp" "v0.5.1"
github "pinterest/PINCache" "3.0.1-beta.4"
github "pinterest/PINCache" "3.0.1-beta.5"
github "pinterest/PINOperation"
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ carthage:
carthage update --no-use-binaries --no-build
carthage build --no-skip-current

all: test carthage lint analyze
all: carthage test lint analyze
2 changes: 1 addition & 1 deletion PINRemoteImage.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Pod::Spec.new do |s|

s.subspec "PINCache" do |pc|
pc.dependency 'PINRemoteImage/Core'
pc.dependency 'PINCache', '=3.0.1-beta.4'
pc.dependency 'PINCache', '=3.0.1-beta.5'
pc.source_files = 'Source/Classes/PINCache/*.{h,m}'
end

Expand Down
2 changes: 1 addition & 1 deletion Source/Classes/PINRemoteImageManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ - (nonnull instancetype)initWithSessionConfiguration:(nullable NSURLSessionConfi
return [NSKeyedUnarchiver unarchiveObjectWithData:data];
}
return data;
} fileExtension:nil];
}];
#else
return [[PINRemoteImageBasicCache alloc] init];
#endif
Expand Down
2 changes: 1 addition & 1 deletion Tests/PINRemoteImageTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ - (void)testInvalidObject
return [NSKeyedArchiver archivedDataWithRootObject:object];
} deserializer:^id<NSCoding> _Nonnull(NSData * _Nonnull data, NSString * _Nonnull key) {
return [NSKeyedUnarchiver unarchiveObjectWithData:data];
} fileExtension:nil];
}];

[tempDiskCache setObject:@"invalid" forKey:[self.imageManager cacheKeyForURL:[self JPEGURL] processorKey:nil]];

Expand Down

0 comments on commit 2a8f62f

Please sign in to comment.