Skip to content

Commit

Permalink
Mark PlatformProvider as deprecated in models (#5512)
Browse files Browse the repository at this point in the history
Signed-off-by: khanhtc1202 <[email protected]>
  • Loading branch information
khanhtc1202 authored Jan 24, 2025
1 parent f50cc80 commit 45d8a20
Show file tree
Hide file tree
Showing 6 changed files with 356 additions and 345 deletions.
194 changes: 99 additions & 95 deletions pkg/model/application.pb.go

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions pkg/model/application.proto
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@ message Application {
ApplicationKind kind = 6 [(validate.rules).enum.defined_only = true];
// The path to the git directory of this application.
ApplicationGitPath git_path = 7 [(validate.rules).message.required = true];
// NOTE: Fields `cloud_provider` and `platform_provider` are deprecated.
// Using `deploy_targets` to specify where to deploy instead.
// The name of cloud provider where to deploy this application.
// This must be one of the provider names registered in the piped.
string cloud_provider = 8 [deprecated=true];
// The name of platform provider where to deploy this application.
// This must be one of the provider names registered in the piped.
// TODO: Add validation for this field.
string platform_provider = 15;
string platform_provider = 15 [deprecated=true];
// The names of deploy taget where to deploy this application.
repeated string deploy_targets = 16;
// Additional description about application.
Expand Down
Loading

0 comments on commit 45d8a20

Please sign in to comment.