Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fields on deployment trace model to be not required #5619

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

khanhtc1202
Copy link
Member

What this PR does:

Mark title and auth field in deployment trace model as not required

Why we need it:

We changed our thoughts on the required field in the deployment trace model. Users are not required to submit all the commit info in order to use the deployment trace feature

Which issue(s) this PR fixes:

Follow #5580

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.57%. Comparing base (04394f5) to head (3908a0d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5619   +/-   ##
=======================================
  Coverage   26.57%   26.57%           
=======================================
  Files         475      475           
  Lines       50592    50592           
=======================================
+ Hits        13444    13447    +3     
+ Misses      36085    36083    -2     
+ Partials     1063     1062    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Warashi
Warashi previously approved these changes Mar 4, 2025
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: khanhtc1202 <[email protected]>
@khanhtc1202
Copy link
Member Author

@Warashi please reapprove, I updated the lint failure

@khanhtc1202 khanhtc1202 closed this Mar 4, 2025
@khanhtc1202 khanhtc1202 reopened this Mar 4, 2025
@khanhtc1202 khanhtc1202 merged commit 874278e into master Mar 4, 2025
28 checks passed
@khanhtc1202 khanhtc1202 deleted the update-deployment-trace-model branch March 4, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants