Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fields on deployment trace model to be not required #5619

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Change fields on deployment trace model to be not required #5619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ada42f6
Change fields on deployment trace model to be not required
khanhtc1202 Mar 4, 2025
3908a0d
Fix lint
khanhtc1202 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 23 additions & 35 deletions pkg/model/deployment_trace.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 2 additions & 31 deletions pkg/model/deployment_trace.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions pkg/model/deployment_trace.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,13 @@ import "validate/validate.proto";

message DeploymentTrace {
string id = 1 [(validate.rules).string.min_len = 1];
string title = 2 [(validate.rules).string.min_len = 1];
string title = 2;
string commit_hash = 3 [(validate.rules).string.min_len = 1];
string commit_url = 4 [(validate.rules).string.min_len = 1];
string commit_message = 5;
int64 commit_timestamp = 6 [(validate.rules).int64.gte = 0];
string author = 7 [(validate.rules).string.min_len = 1];
string author = 7;

int64 completed_at = 100 [(validate.rules).int64.gte = 0];
int64 created_at = 101 [(validate.rules).int64.gte = 0];
int64 updated_at = 102 [(validate.rules).int64.gte = 0];
}
4 changes: 0 additions & 4 deletions web/model/deployment_trace_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ export class DeploymentTrace extends jspb.Message {
getAuthor(): string;
setAuthor(value: string): DeploymentTrace;

getCompletedAt(): number;
setCompletedAt(value: number): DeploymentTrace;

getCreatedAt(): number;
setCreatedAt(value: number): DeploymentTrace;

Expand All @@ -51,7 +48,6 @@ export namespace DeploymentTrace {
commitMessage: string,
commitTimestamp: number,
author: string,
completedAt: number,
createdAt: number,
updatedAt: number,
}
Expand Down
30 changes: 0 additions & 30 deletions web/model/deployment_trace_pb.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion web/src/__fixtures__/dummy-deployment-trace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export const dummyDeploymentTrace: ListDeploymentTracesResponse.DeploymentTraceR
commitUrl: "commit-url",
createdAt: createdAt.unix(),
updatedAt: completedAt.unix(),
completedAt: completedAt.unix(),
},
deploymentsList: [dummyDeployment],
};