Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft rfc for livestate feature in plugin architecture #5364

Merged

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Nov 25, 2024

What this PR does:

as title

Why we need it:

Which issue(s) this PR fixes:

Part of #5363

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@ffjlabo ffjlabo force-pushed the add-rfc-for-livestate-feature-for-plugin-architecture branch from a8568b4 to a5bf076 Compare November 25, 2024 05:45
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.44%. Comparing base (b8070a9) to head (a5bf076).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5364   +/-   ##
=======================================
  Coverage   25.44%   25.44%           
=======================================
  Files         446      446           
  Lines       47844    47844           
=======================================
  Hits        12172    12172           
  Misses      34720    34720           
  Partials      952      952           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great flow chart!

It seems complex to handle some points which are specific to some plugins.
e.g. pass it to the executor.Input and use it on the k8s stage

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffjlabo
Copy link
Member Author

ffjlabo commented Nov 25, 2024

It seems complex to handle some points which are specific to some plugins.
e.g. pass it to the executor.Input and use it on the k8s stage

That's true. In my understanding, livestatestore is used only in the executor.
So I plan to use livestatestore directly from the executor in the plugin side.

@ffjlabo ffjlabo merged commit ab687f3 into master Nov 25, 2024
18 checks passed
@ffjlabo ffjlabo deleted the add-rfc-for-livestate-feature-for-plugin-architecture branch November 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants