Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MigrateDatabase RPC #5497

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jan 20, 2025

What this PR does:

as title

Why we need it:

When developing pipedv1, we have to use data with new fields, such as deploy target, or we have to patch pipedv1 temporarily to use the old field.
This PR implements the server side.

Follows #5476

Which issue(s) this PR fixes:

Part of #4980
Part of #5252

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 26.21%. Comparing base (786bf3d) to head (4519815).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/server/grpcapi/api.go 0.00% 21 Missing ⚠️
pkg/datastore/datastoretest/datastore.mock.go 0.00% 8 Missing ⚠️
pkg/datastore/applicationstore.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5497      +/-   ##
==========================================
- Coverage   26.23%   26.21%   -0.02%     
==========================================
  Files         460      460              
  Lines       49370    49404      +34     
==========================================
  Hits        12952    12952              
- Misses      35389    35423      +34     
  Partials     1029     1029              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review January 20, 2025 07:14
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 1fef133 into master Jan 21, 2025
16 of 18 checks passed
@Warashi Warashi deleted the server-migrate-application-model branch January 21, 2025 02:40
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants