[WAIT] Use metadataStore in the wait stage plugin #5520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
khanhtc1202,
ffjlabo and
Warashi
as code owners
14 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5520 +/- ##
==========================================
- Coverage 26.43% 26.43% -0.01%
==========================================
Files 464 464
Lines 49786 49793 +7
==========================================
Hits 13163 13163
- Misses 35569 35576 +7
Partials 1054 1054 ☔ View full report in Codecov by Sentry. |
Warashi
reviewed
Jan 31, 2025
Comment on lines
92
to
105
| func (s *deploymentServiceServer) retrieveStartTime(ctx context.Context, deploymentID, stageID string) (t time.Time) { | ||
| sec, err := s.metadataStore.GetStageMetadata(ctx, &pipedservice.GetStageMetadataRequest{ | ||
| DeploymentId: deploymentID, | ||
| StageId: stageID, | ||
| Key: startTimeKey, | ||
| }) | ||
| if err != nil { | ||
| s.logger.Error(fmt.Sprintf("failed to get stage metadata %s", startTimeKey), zap.Error(err)) | ||
| return | ||
| } | ||
| ut, err := strconv.ParseInt(sec.Value, 10, 64) | ||
| if err != nil { | ||
| s.logger.Error(fmt.Sprintf("failed to parse stage metadata %s", startTimeKey), zap.Error(err)) | ||
| return |
There was a problem hiding this comment.
[IMO]
I don't like naked returns, and named result parameters that don't clarify the usage of their return values.
ref; https://go.dev/wiki/CodeReviewComments#named-result-parameters
Signed-off-by: t-kikuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: