[Stage Plugins] Add availableOperation in the PipelineStage model
#5522
Conversation
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
khanhtc1202,
ffjlabo and
Warashi
as code owners
pkg/model/deployment.proto
Outdated
| // Whether this stage can be skipped by a user via UI. | ||
| bool skippable = 16; | ||
| // Whether this stage can be approved by a user via UI. | ||
| bool approvable = 17; |
There was a problem hiding this comment.
I named it approvable, not like waits_approval because it depends on whether a plugin waits for approvals.
If you have any idea of the name, please share 🙏
There was a problem hiding this comment.
How about making these flags as enum field like candidate_ui_action?
We don't have a use case for both skippable and approvable are set true for now, so we can make them a single field.
There was a problem hiding this comment.
Thank you, it seems greater.
I fixed as below:
Let's make it repeated when needed in the future.
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5522 +/- ##
=======================================
Coverage 26.43% 26.44%
=======================================
Files 464 465 +1
Lines 49786 49858 +72
=======================================
+ Hits 13163 13186 +23
- Misses 35569 35618 +49
Partials 1054 1054 ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
changed the title
skippable and approvable flags in the PipelineStage modelavailableOperation in the PipelineStage model
What this PR does:
as title
Why we need it:
cf. See here for the overview of skipStage/ApproveStage: #5367 (comment)
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: