Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy target by plugin to deployment #5544

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Feb 6, 2025

What this PR does:

as title

Follow: #5543

Why we need it:

Which issue(s) this PR fixes:

Part of #4980 #5252

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 26.42%. Comparing base (ea25ab8) to head (626fbad).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/model/deployment.go 0.00% 10 Missing ⚠️
...p/pipedv1/plugin/kubernetes/deployment/rollback.go 0.00% 6 Missing ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/sync.go 33.33% 3 Missing and 1 partial ⚠️
pkg/app/piped/trigger/deployment.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/trigger/deployment.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5544      +/-   ##
==========================================
- Coverage   26.43%   26.42%   -0.02%     
==========================================
  Files         465      465              
  Lines       49885    49905      +20     
==========================================
- Hits        13188    13185       -3     
- Misses      35643    35664      +21     
- Partials     1054     1056       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo ffjlabo merged commit 8911199 into master Feb 6, 2025
16 of 18 checks passed
@ffjlabo ffjlabo deleted the add-deployTargetByPlugin-to-deployment branch February 6, 2025 09:27
ffjlabo added a commit that referenced this pull request Feb 7, 2025
ffjlabo added a commit that referenced this pull request Feb 7, 2025
This reverts commit 8911199.

Signed-off-by: Yoshiki Fujikane <[email protected]>
khanhtc1202 pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants