Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins to piped model #5545

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Add plugins to piped model #5545

merged 2 commits into from
Feb 6, 2025

Conversation

khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

We need to use plugins' information in the application form on the UI. This PR adds the plugin information to the piped model, and when piped is fetched and shown on the UI, we can have plugin info to use.

Which issue(s) this PR fixes:

Part of #5252

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) February 6, 2025 09:35
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 26.41%. Comparing base (ea25ab8) to head (2e15425).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/datastore/datastoretest/datastore.mock.go 0.00% 4 Missing ⚠️
pkg/datastore/pipedstore.go 0.00% 2 Missing ⚠️
pkg/app/server/grpcapi/piped_api.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5545      +/-   ##
==========================================
- Coverage   26.43%   26.41%   -0.03%     
==========================================
  Files         465      465              
  Lines       49885    49907      +22     
==========================================
- Hits        13188    13181       -7     
- Misses      35643    35671      +28     
- Partials     1054     1055       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit 4eee290 into master Feb 6, 2025
16 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the update-piped-model branch February 6, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants