Add deploy target by plugin to application web API #5547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
requested review from
ffjlabo,
t-kikuc and
Warashi
as code owners
khanhtc1202
commented
Feb 6, 2025
| @@ -361,7 +361,7 @@ func (a *API) UpdateApplication(ctx context.Context, req *apiservice.UpdateAppli | |||
| return nil, status.Error(codes.InvalidArgument, "Requested piped does not belong to your project") | |||
| } | |||
|
|
|||
| if err := a.applicationStore.UpdateConfiguration(ctx, req.ApplicationId, req.PipedId, req.PlatformProvider, req.GitPath.ConfigFilename); err != nil { | |||
| if err := a.applicationStore.UpdateConfiguration(ctx, req.ApplicationId, req.PipedId, req.PlatformProvider, req.GitPath.ConfigFilename, nil); err != nil { | |||
There was a problem hiding this comment.
Just pass nil here and not update the grpc for this API since this one is used by pipectl and outer tool (like https://github.com/pipe-cd/terraform-provider-pipecd), I will consider to update this later
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5547 +/- ##
==========================================
+ Coverage 26.40% 26.42% +0.01%
==========================================
Files 465 465
Lines 49907 49909 +2
==========================================
+ Hits 13179 13189 +10
+ Misses 35672 35665 -7
+ Partials 1056 1055 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
These API will be used by forms in Web UI to register and edit application
Which issue(s) this PR fixes:
Part of #5252
Does this PR introduce a user-facing change?: