Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type definition for DeployTargetsByPlugin #5555

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Feb 7, 2025

What this PR does:

sd title

Why we need it:

We can't use type google.protobuf.ListValue because Firestore SDK doesn't treat the type.

Which issue(s) this PR fixes:

Part of #4980 #5252
Follow #5553 #5554

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

khanhtc1202
khanhtc1202 previously approved these changes Feb 7, 2025
t-kikuc
t-kikuc previously approved these changes Feb 7, 2025
Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo ffjlabo dismissed stale reviews from t-kikuc and khanhtc1202 via 98e25cb February 7, 2025 08:34
Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo ffjlabo enabled auto-merge (squash) February 7, 2025 08:39
@ffjlabo ffjlabo requested a review from t-kikuc February 7, 2025 08:41
@ffjlabo ffjlabo merged commit ed28c89 into master Feb 7, 2025
14 of 16 checks passed
@ffjlabo ffjlabo deleted the fix-deployTargetsByPlugin-definition branch February 7, 2025 08:44
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 3.92157% with 49 lines in your changes missing coverage. Please review.

Project coverage is 26.43%. Comparing base (1e2231f) to head (e975b7b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipectl/cmd/migrate/database.go 0.00% 18 Missing ⚠️
...p/pipedv1/plugin/kubernetes/deployment/rollback.go 0.00% 6 Missing ⚠️
pkg/model/application.go 0.00% 6 Missing ⚠️
pkg/model/deployment.go 0.00% 6 Missing ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/sync.go 33.33% 3 Missing and 1 partial ⚠️
pkg/datastore/datastoretest/datastore.mock.go 0.00% 4 Missing ⚠️
pkg/datastore/applicationstore.go 0.00% 2 Missing ⚠️
pkg/app/piped/trigger/deployment.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/trigger/deployment.go 0.00% 1 Missing ⚠️
pkg/app/server/grpcapi/api.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5555      +/-   ##
==========================================
- Coverage   26.44%   26.43%   -0.02%     
==========================================
  Files         465      465              
  Lines       49862    49901      +39     
==========================================
+ Hits        13188    13189       +1     
- Misses      35620    35657      +37     
- Partials     1054     1055       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants