Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application form add for piped v1 with deployment targets config #5560

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

hongky-1994
Copy link
Contributor

@hongky-1994 hongky-1994 commented Feb 11, 2025

What this PR does:

  • Update applicaiton form UI for piped v1 with deployment target Select input
add-form-screen-shot edit-form-screen-shot

Why we need it:

  • For adapting API add|edit applicaiton with deployment target config for Piped v1

Which issue(s) this PR fixes:

Part of #5252

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.39%. Comparing base (7d2818a) to head (0ae8b73).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5560   +/-   ##
=======================================
  Coverage   26.38%   26.39%           
=======================================
  Files         465      465           
  Lines       49940    49940           
=======================================
+ Hits        13179    13183    +4     
+ Misses      35705    35702    -3     
+ Partials     1056     1055    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hongky-1994 hongky-1994 marked this pull request as ready for review February 11, 2025 07:55
@hongky-1994 hongky-1994 self-assigned this Feb 11, 2025
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) February 12, 2025 03:31
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@khanhtc1202 khanhtc1202 merged commit 02092ce into master Feb 13, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the feat/form-application-pipe-v1-deploy-targets branch February 13, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants