Show kind="APPLICATION" for item using pipedv1 in App and Deploy List page #5581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page Signed-off-by: kypham <[email protected]>
hongky-1994
requested review from
khanhtc1202,
ffjlabo,
t-kikuc and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5581 +/- ##
==========================================
+ Coverage 26.28% 26.30% +0.01%
==========================================
Files 469 469
Lines 50323 50323
==========================================
+ Hits 13229 13235 +6
+ Misses 36033 36027 -6
Partials 1061 1061 ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
Feb 18, 2025
| @@ -136,6 +141,11 @@ export const ApplicationListItem: FC<ApplicationListItemProps> = memo( | |||
|
|
|||
| const recentlyDeployment = app.mostRecentlySuccessfulDeployment; | |||
|
|
|||
| const pipedVersion = | |||
There was a problem hiding this comment.
[nit] Refactor to move this logic and enum to one place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Part of #5252 #5509
Does this PR introduce a user-facing change?: no