[WAIT,SDK] Implemented Wait stage with SDK #5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
…n/wait-use-sdk
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
khanhtc1202,
ffjlabo and
Warashi
as code owners
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5586 +/- ##
==========================================
+ Coverage 26.24% 26.27% +0.02%
==========================================
Files 471 470 -1
Lines 50421 50353 -68
==========================================
- Hits 13235 13228 -7
+ Misses 36125 36065 -60
+ Partials 1061 1060 -1 ☔ View full report in Codecov by Sentry. |
ffjlabo
approved these changes
Feb 19, 2025
Warashi
approved these changes
Feb 19, 2025
Comment on lines
+187
to
+191
| // b, err := json.Marshal(stage) | ||
| // if err != nil { | ||
| // return nil, false | ||
| // } | ||
| // return b, true |
There was a problem hiding this comment.
📝
We should remove these lines in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
PipelineStage.Within schedulerWhy we need it:
it's simpler to use SDK for stage plugins
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: