Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Rename PipelineSyncPlugin to StagePlugin (missed to rename) #5593

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Feb 20, 2025

What this PR does:

as title.
some methods were not fixed yet.

Why we need it:

To be consistent

Which issue(s) this PR fixes:

Part of #5530
Follows #5587

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 26.26%. Comparing base (7b78a17) to head (69bb589).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/deployment.go 0.00% 13 Missing ⚠️
pkg/app/pipedv1/plugin/example/main.go 0.00% 1 Missing ⚠️
...app/pipedv1/plugin/kubernetes_multicluster/main.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/plugin/wait/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5593   +/-   ##
=======================================
  Coverage   26.26%   26.26%           
=======================================
  Files         472      472           
  Lines       50388    50388           
=======================================
  Hits        13234    13234           
  Misses      36094    36094           
  Partials     1060     1060           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit ad00a56 into master Feb 20, 2025
17 of 18 checks passed
@t-kikuc t-kikuc deleted the plugin/sdk/rename-2 branch February 20, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants