Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for StagePlugin SDK and enum conversion #5604

Merged
merged 8 commits into from
Feb 26, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Feb 26, 2025

What this PR does:

as title

Why we need it:

To build a robust SDK

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.52%. Comparing base (c1a62c5) to head (a9e59a4).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5604      +/-   ##
==========================================
+ Coverage   26.27%   26.52%   +0.24%     
==========================================
  Files         474      474              
  Lines       50475    50496      +21     
==========================================
+ Hits        13263    13394     +131     
+ Misses      36150    36039     -111     
- Partials     1062     1063       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review February 26, 2025 06:05
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit 855aa0a into master Feb 26, 2025
18 checks passed
@t-kikuc t-kikuc deleted the deployment-plugin-test branch February 26, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants