Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy_targets field to GetLivestateRequest message #5618

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Add deploy_targets field to GetLivestateRequest message #5618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 37 additions & 26 deletions pkg/plugin/api/v1alpha1/livestate/api.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/plugin/api/v1alpha1/livestate/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ service LivestateService {
message GetLivestateRequest {
string application_id = 1;
grpc.plugin.common.v1alpha1.DeploymentSource deploy_source = 2;
repeated string deploy_targets = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ask] Are these fields required or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the application ID seems required, but the others are plugin-dependent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I got it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, all should be required since this is livestate, so common plugins (like wait, wait approval) would not use this; only platform-based plugins use these fields, so should mark as required, wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you about the plugins I can imagine now. But I think we should not restrict the possibility of third-party plugins that don't use these fields.

}

message GetLivestateResponse {
Expand Down