Create and add deployment trace obj to datastore on event registering flow #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flow Signed-off-by: khanhtc1202 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5622 +/- ##
==========================================
- Coverage 26.56% 26.53% -0.03%
==========================================
Files 475 477 +2
Lines 50582 50661 +79
==========================================
+ Hits 13438 13444 +6
- Misses 36081 36154 +73
Partials 1063 1063 ☔ View full report in Codecov by Sentry. |
khanhtc1202
commented
Mar 4, 2025
| @@ -103,3 +103,16 @@ CREATE TABLE IF NOT EXISTS DeploymentChain ( | |||
| CreatedAt INT(11) GENERATED ALWAYS AS (data->>"$.created_at") STORED NOT NULL, | |||
| UpdatedAt INT(11) GENERATED ALWAYS AS (data->>"$.updated_at") STORED NOT NULL | |||
| ) ENGINE=InnoDB; | |||
|
|
|||
There was a problem hiding this comment.
This change is enable using MySQL as the datastore of ControlPlane; each time we have a new objStore (DeploymentTraceStore at this time), we need to create a new table in MySQL schema.
khanhtc1202
commented
Mar 4, 2025
Comment on lines
+26
to
+70
| type deploymentTraceCollection struct { | ||
| requestedBy Commander | ||
| } | ||
|
|
||
| func (d *deploymentTraceCollection) Kind() string { | ||
| return "DeploymentTrace" | ||
| } | ||
|
|
||
| func (d *deploymentTraceCollection) Factory() Factory { | ||
| return func() interface{} { | ||
| return &model.DeploymentTrace{} | ||
| } | ||
| } | ||
|
|
||
| func (d *deploymentTraceCollection) ListInUsedShards() []Shard { | ||
| return []Shard{ | ||
| AgentShard, | ||
| } | ||
| } | ||
|
|
||
| func (d *deploymentTraceCollection) GetUpdatableShard() (Shard, error) { | ||
| switch d.requestedBy { | ||
| case PipedCommander: | ||
| return AgentShard, nil | ||
| default: | ||
| return "", ErrUnsupported | ||
| } | ||
| } | ||
|
|
||
| func (d *deploymentTraceCollection) Encode(entity interface{}) (map[Shard][]byte, error) { | ||
| const errFmt = "failed while encode Deployment Trace object: %s" | ||
|
|
||
| me, ok := entity.(*model.DeploymentTrace) | ||
| if !ok { | ||
| return nil, fmt.Errorf(errFmt, "type not matched") | ||
| } | ||
|
|
||
| data, err := json.Marshal(me) | ||
| if err != nil { | ||
| return nil, fmt.Errorf(errFmt, "unable to marshal entity data") | ||
| } | ||
| return map[Shard][]byte{ | ||
| AgentShard: data, | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
This change is to enable support filedb as db of the pipecd. I'm thinking about deprecated this filedb feature since we're not actively maintaining these parts. Let's ignore this while reviewing this PR 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
While registering an event by pipette, we will create a DeploymentTrace object and store it in the datastore. The stored DeploymentTrace object contains information about the commit that triggered the event, which will be used in the DeploymentTrace feature UI.
Also, I updated the Event model to store trigger_commit_hash, which is the commit hash of the commit that triggers this event. This information will be used while handling the event (EventWatcher handling flow)
Which issue(s) this PR fixes:
Part of #5444
Does this PR introduce a user-facing change?: