Merge pull request #105 from planetlabs/sorted-imports

Configure import sorting
planetlabs · Jan 9, 2025 · dcf6e9d · dcf6e9d
2 parents 0c07d15 + e8adf38
commit dcf6e9d
Show file tree

Hide file tree

Showing 6 changed files with 44 additions and 101 deletions.
diff --git a/examples/es6/main.js b/examples/es6/main.js
@@ -1,6 +1,6 @@
-import foo from './local-module.js';
 import fs from 'fs';
 import path from 'path';
+import foo from './local-module.js';
 
 const main = paths =>
   Promise.all(

diff --git a/examples/react/component.js b/examples/react/component.js
@@ -1,6 +1,6 @@
+import {string} from 'prop-types';
 import React, {useCallback, useState} from 'react';
 import ReactDOM from 'react-dom';
-import {string} from 'prop-types';
 
 const HelloMessage = ({name}) => {
   const [greeting, setGreeting] = useState('Hello');

diff --git a/index.js b/index.js
@@ -1,8 +1,7 @@
-import globals from 'globals';
-import importPlugin from 'eslint-plugin-import';
 import js from '@eslint/js';
+import importPlugin from 'eslint-plugin-import';
 import prettier from 'eslint-plugin-prettier';
-import sortImportPlugin from 'eslint-plugin-sort-imports-es6-autofix';
+import globals from 'globals';
 
 export default [
   js.configs.recommended,
@@ -11,7 +10,6 @@ export default [
     name: 'planet/recommended',
     plugins: {
       prettier,
-      'sort-imports-es6-autofix': sortImportPlugin,
     },
 
     languageOptions: {
@@ -25,41 +23,13 @@ export default [
     },
 
     rules: {
+      // core rules
       'array-callback-return': 'error',
       'block-scoped-var': 'error',
       curly: 'error',
       'default-case': 'error',
-
-      'dot-notation': [
-        'error',
-        {
-          allowPattern: '^[a-z]+(_[a-z]+)+$',
-        },
-      ],
-
+      'dot-notation': ['error', {allowPattern: '^[a-z]+(_[a-z]+)+$'}],
       eqeqeq: 'error',
-      'import/default': 'error',
-
-      'import/extensions': [
-        'error',
-        'always',
-        {
-          ignorePackages: true,
-        },
-      ],
-
-      'import/first': 'error',
-      'import/named': 'error',
-      'import/no-duplicates': 'error',
-      'import/no-self-import': 'error',
-
-      'import/no-unresolved': [
-        'error',
-        {
-          commonjs: true,
-        },
-      ],
-
       'no-case-declarations': 'error',
       'no-cond-assign': 'error',
       'no-console': 'error',
@@ -94,40 +64,29 @@ export default [
       'no-unexpected-multiline': 'error',
       'no-unreachable': 'error',
       'no-unsafe-finally': 'error',
-
-      'no-unused-vars': [
-        'error',
-        {
-          ignoreRestSiblings: true,
-        },
-      ],
-
+      'no-unused-vars': ['error', {ignoreRestSiblings: true}],
       'no-use-before-define': ['error', 'nofunc'],
       'no-var': 'error',
       'prefer-const': 'error',
-
-      'prettier/prettier': [
-        'error',
-        {
-          singleQuote: true,
-          bracketSpacing: false,
-          arrowParens: 'avoid',
-        },
-      ],
-
       strict: 'off',
+      'use-isnan': 'error',
+      'valid-typeof': 'error',
 
-      'sort-imports-es6-autofix/sort-imports-es6': [
+      // import plugin
+      'import/default': 'error',
+      'import/extensions': ['error', 'always', {ignorePackages: true}],
+      'import/first': 'error',
+      'import/named': 'error',
+      'import/no-duplicates': 'error',
+      'import/no-self-import': 'error',
+      'import/no-unresolved': ['error', {commonjs: true}],
+      'import/order': ['error', {named: true, alphabetize: {order: 'asc'}}],
+
+      // prettier plugin
+      'prettier/prettier': [
         'error',
-        {
-          ignoreCase: false,
-          ignoreMemberSort: false,
-          memberSyntaxSortOrder: ['none', 'all', 'single', 'multiple'],
-        },
+        {singleQuote: true, bracketSpacing: false, arrowParens: 'avoid'},
       ],
-
-      'use-isnan': 'error',
-      'valid-typeof': 'error',
     },
   },
 ];
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -32,7 +32,6 @@
     "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-react": "^7.37.3",
     "eslint-plugin-react-hooks": "5.0.0",
-    "eslint-plugin-sort-imports-es6-autofix": "^0.6.0",
     "globals": "^15.14.0",
     "prettier": "^3.4.2"
   }

diff --git a/react.js b/react.js
@@ -1,6 +1,6 @@
-import planetConfig from './index.js';
 import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
+import planetConfig from './index.js';
 
 export default [
   ...planetConfig,