fix multiple planetscale_database param handling bugs
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mark `cluster_size` as required - mark `cluster_size` as requiring recreate (destroy+create), pending: #107 - fix `issues_count` marked as a changeable param, it is readonly - fix `multiple_admins_required_for_deletion` marked as a changeable param, it is readonly - fix `plan` marked as a changeable param, it is readonly - refactor `planetscale_database` tests to include coverage of all changeable params Also: - Update goreleaser.yml to address deprecations
joemiller
changed the title
planetscale_database resource required and optional paramsplanetscale_database param handling bugs
When `automatic_migration` is set to `true` the `migration_table_name` and `migration_framework` values also need to be set.
joemiller
force-pushed
the
joem/database-fix-updateable-settings
branch
from
a80e87e to
8cbd103
Compare
Sinjo
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster_sizeas requiredcluster_sizeas requiring recreate (destroy+create), pending: changeplanetscale_databasecluster_sizewithout replace #107issues_countmarked as a changeable param, it is readonlymultiple_admins_required_for_deletionmarked as a changeable param, it is readonlyplanmarked as a changeable param, it is readonlyautomatic_migrationsistrue,migration_frameworkandmigration_table_namemust be setplanetscale_databasetests to include coverage of all changeable paramsAlso: