Syncfork #85
Closed
Syncfork #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or tables (vitessio#13442) * schema.Reload(): ignore column reading errors for views only, error for tables Signed-off-by: Shlomi Noach <[email protected]> * restore to pre-PR Signed-off-by: Shlomi Noach <[email protected]> * add ERNoSuchUser error (view's definer not found) Signed-off-by: Shlomi Noach <[email protected]> * Error Signed-off-by: Shlomi Noach <[email protected]> * ignore either missing columns or unknown definer -- for views Signed-off-by: Shlomi Noach <[email protected]> * adapt tests Signed-off-by: Shlomi Noach <[email protected]> * cleanup Signed-off-by: Shlomi Noach <[email protected]> * update comment Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
* added kill statement in parser Signed-off-by: Harshit Gangal <[email protected]> * add support for executing kill statement Signed-off-by: Harshit Gangal <[email protected]> * added e2e test for kill statement Signed-off-by: Harshit Gangal <[email protected]> * added more e2e test Signed-off-by: Harshit Gangal <[email protected]> * added unit test Signed-off-by: Harshit Gangal <[email protected]> * introduce closing bool for connection to check if connection is usable or not Signed-off-by: Harshit Gangal <[email protected]> * updated the test Signed-off-by: Harshit Gangal <[email protected]> * add allow-kill-statement flag to enable kill statement Signed-off-by: Harshit Gangal <[email protected]> * updated the test help output expectation Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
…#13434) * tcp keep alive and period settings Signed-off-by: Harshit Gangal <[email protected]> * added e2e test for tcp keep alive Signed-off-by: Harshit Gangal <[email protected]> * added unit test and removed e2e test due to cgo dependency Signed-off-by: Harshit Gangal <[email protected]> * addressed review comments Signed-off-by: Harshit Gangal <[email protected]> * introduce a marker on conn to know if keepalive is on, used for testing Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
…se-fix-consul-tag `examples/compose`: fix `consul:latest` error w/`docker-compose up -d`
Signed-off-by: Jimmy Kim <[email protected]>
peterlyoo
requested review from
GuptaManan100,
frouioui,
rohit-nayak-ps,
deepthi,
mattlord,
harshit-gangal,
systay,
shlomi-noach,
ajm188 and
notfelineit
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes