Code

Handle missing scroll depth #2#5017

Code

Merged

macobo merged 23 commits intomasterplausible/analytics:masterfrom missing-scroll-depthplausible/analytics:missing-scroll-depthCopy head branch name to clipboardJan 29, 2025

+455-164

Commits

Commits on Jan 14, 2025

• add migration

  RobertJoonas

  committed
  c3c1039

  Copy full SHA for c3c1039

Commits on Jan 15, 2025

• move scroll_depth_enabled? fn

  RobertJoonas

  committed
  7974895

  Copy full SHA for 7974895

• maybe set engagement_metrics_enabled_at when requesting dashboard

  RobertJoonas

  committed
  4d02ae4

  Copy full SHA for 4d02ae4

• maybe set engagement_metrics_enabled_at in shared_link action

  RobertJoonas

  committed
  8ab805b

  Copy full SHA for 8ab805b

• maybe set engagement_metrics_enabled_at on full export

  RobertJoonas

  committed
  9850450

  Copy full SHA for 9850450

Commits on Jan 16, 2025

• fix tests

  RobertJoonas

  committed
  fb279b3

  Copy full SHA for fb279b3

• feature gate scroll depth on the dashboard with site.engagement_metrics_enabled_at

  RobertJoonas

  committed
  cdf2c83

  Copy full SHA for cdf2c83

• feature gate scroll depth in full export too

  RobertJoonas

  committed
  19fdda7

  Copy full SHA for 19fdda7

• fix npm ci

  RobertJoonas

  committed
  8c3c922

  Copy full SHA for 8c3c922

Commits on Jan 23, 2025

• Rename things into FE, remove unneccessary flag checks

  macobo

  committed
  9631f60

  Copy full SHA for 9631f60

• Continue with renaming

  macobo

  committed
  cc26755

  Copy full SHA for cc26755

• Merge remote-tracking branch 'origin/master' into handle-missing-scroll-depth

  macobo

  committed
  8ea7088

  Copy full SHA for 8ea7088

• Rename site flag to be more descriptive

  macobo

  committed
  8ea9eca

  Copy full SHA for 8ea9eca

• Move business logic, calculate based on scroll depth, make more precalculatable

  macobo

  committed
  80fc6c6

  Copy full SHA for 80fc6c6

• Some docs

  macobo

  committed
  cf2bb17

  Copy full SHA for cf2bb17

• Rename to site.scrollDepthVisible in frontend

  macobo

  committed
  7c1bf77

  Copy full SHA for 7c1bf77

Commits on Jan 27, 2025

• Update migration

  macobo

  committed
  422ed9a

  Copy full SHA for 422ed9a

• Fix template

  macobo

  committed
  957f029

  Copy full SHA for 957f029

• Remove boilerplate from tests

  macobo

  committed
  3a94d2c

  Copy full SHA for 3a94d2c

• Update tests

  macobo

  committed
  a6516cd

  Copy full SHA for a6516cd

• More straight-forward test

  macobo

  committed
  8586103

  Copy full SHA for 8586103

Commits on Jan 28, 2025

• Update condition

  macobo

  committed
  9132205

  Copy full SHA for 9132205

• Merge remote-tracking branch 'origin/master' into missing-scroll-depth

  macobo

  committed
  09fb06b

  Copy full SHA for 09fb06b