Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker: Use fetch with keepalive over beacon for pageleaves #5020

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Tracker: Use fetch with keepalive over beacon for pageleaves #5020

merged 2 commits into from
Jan 27, 2025

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jan 27, 2025

Changes

🤦 I didn't realize pageleaves had their own tracking code. After this change fetch with keepalive is used instead of beacon.

@macobo macobo requested a review from RobertJoonas January 27, 2025 09:02
RobertJoonas
RobertJoonas approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@RobertJoonas RobertJoonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, can't believe I missed that too 🤯

Looks good to me other than the CI - including data-allow-fetch in all snippets of the relevant html test fixtures should do the trick.

@macobo macobo enabled auto-merge January 27, 2025 10:10
@macobo macobo added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit a372096 Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertJoonas RobertJoonas RobertJoonas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macobo @RobertJoonas