Change "My Team" to "My Personal Sites" and expose it in sites list #5132
+204
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aerosol
reviewed
Mar 3, 2025
| if site.team.name == "My Team" do | ||
| owner.name | ||
| else | ||
| if site.team.setup_complete do |
aerosol
reviewed
Mar 3, 2025
| @@ -12,6 +12,14 @@ defmodule Plausible.Teams do | |||
|
|
|||
| @accept_traffic_until_free ~D[2135-01-01] | |||
|
|
|||
| @spec default_name() :: String.t() | |||
| def default_name(), do: "My Personal Sites" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR renames "My Team" to "My Personal Sites" when team's setup is not complete yet.
It also enforces team name change during setup, treating "My Personal Sites" as reserved name. There's a default generated on the basis of user's name.
The CTA is also rephrased to "Setup Team" instead of "Create Team" to express the intent better.
The team name is now used in place of "My Sites" heading in sites list view to clearly identify which team the user is switched to. The "My Personal Sites" heading is also the default for a case where user is not a member of any team yet.
The heading change is hidden behind a flag for now.
The migration renaming the teams will be extracted and deployed independently after the PR is approved.
Tests