Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump elixir.yml cache version to fix a test #5143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Mar 5, 2025

A test in test/plausible_web/plugs/tracker_test.exs was failing due to cached version of tracker script being used in other PRs.

The reason it didn't fail in the original PR adding the test was that changes in tracker script bypassed the cache for that pr. The old cached data was still used for other PRs, causing them to fail.

A test in test/plausible_web/plugs/tracker_test.exs was failing due to
cached version of tracker script being used in other PRs.

The reason it didn't fail in the original PR adding the test was that
changes in tracker script bypassed the cache **for that pr**.
@macobo macobo requested a review from a team March 5, 2025 09:27
@aerosol
Copy link
Member

aerosol commented Mar 5, 2025

What's the reason for local failures though?

@macobo
Copy link
Contributor Author

macobo commented Mar 5, 2025

I wasn't able to reproduce a local failure - the first time was because script compilation was still running. 🤦

Do you still receive the same error if you do the following commands:

cd tracker
rm -rf node_modules/
npm i
npm run deploy
cd ..
mix test test/plausible_web/plugs/tracker_test.exs

If you do, what does ls -laht --full-time priv/tracker/js/ | grep -E "plausible.js|plausible.pageleave.js" report?

@aerosol
Copy link
Member

aerosol commented Mar 5, 2025

the first time was because script compilation was still running.

that must've been it here as well. It does not give any indication of running so I must've assumed it was idle...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants