Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gradle #12006

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Support Gradle #12006

merged 3 commits into from
Mar 4, 2024

Conversation

ihostage
Copy link
Member

@ihostage ihostage commented Oct 4, 2023

Fixes

Fixes #11990

@ihostage ihostage added ci:skip-tests Skip 'tests' job in CI builds ci:skip-docs-tests Skip 'docs-tests' job in CI builds ci:skip-scripted-tests Skip 'scripted-tests' job in CI builds labels Oct 4, 2023
@ihostage ihostage force-pushed the gradle branch 2 times, most recently from b3c3856 to 5e0dcff Compare November 15, 2023 12:34
@mkurz mkurz mentioned this pull request Nov 16, 2023
Merged
@ihostage ihostage self-assigned this Nov 23, 2023
@ihostage ihostage force-pushed the gradle branch 4 times, most recently from 537a122 to a071b90 Compare December 4, 2023 11:58
@mkurz mkurz force-pushed the gradle branch 6 times, most recently from ec352e7 to 9a9beb2 Compare December 7, 2023 12:06
@mkurz mkurz mentioned this pull request Dec 7, 2023
Open
@ihostage ihostage force-pushed the gradle branch 3 times, most recently from 28bb972 to 03969c1 Compare December 13, 2023 11:21
@ihostage
Copy link
Member Author

So, I implemented "Aggregating reverse routers" feature and finished adoption to Gradle all our Java examples (except gRPC) in playframework/play-samples#467.
I think we are ready to make announcement of beta testing.

@ihostage ihostage marked this pull request as ready for review December 13, 2023 13:24
@ihostage ihostage requested a review from mkurz December 13, 2023 13:24
@mkurz
Copy link
Member

mkurz commented Dec 13, 2023

Great! Let me take a look tomorrow.

@aalubin
Copy link

aalubin commented Jan 24, 2024

Any update on this?

@ihostage
Copy link
Member Author

Hi, @aalubin! 👋
Yep, today we announced a start of beta-testing 😉

@mkurz mkurz force-pushed the gradle branch 3 times, most recently from ae14cbf to 9f40d1f Compare March 3, 2024 23:14
@mkurz mkurz removed ci:skip-tests Skip 'tests' job in CI builds ci:skip-docs-tests Skip 'docs-tests' job in CI builds ci:skip-scripted-tests Skip 'scripted-tests' job in CI builds labels Mar 3, 2024
@mkurz
Copy link
Member

mkurz commented Mar 3, 2024

@ihostage Please take a look at the commits I pushed:
I renamed the isChanged supplier to triggerReload, because I think this is a bit clearer and I think it's confusing to have the changed variable and an isChanged supplier. (I kept isChanged in the gradle plugin code however, feel free to rename it also if you think it makes sense there).
Because of #12270 we now also have to impliment the generateJsReverseRouter setting in gradle, I did that, please check the last commit.

ihostage and others added 3 commits March 4, 2024 15:11
@ihostage
[Gradle] Initial commit (#11995)
5a05cef
@ihostage
[Gradle] Initial version of Play Gradle Plugin
737be31 
 * Play Routes compiler plugin
 * Play Assets plugin
 * Play Run DEV-mode plugin
 * Support Play application layout
 * Configure Twirl plugin if it was applied
 * Aggregating reverse routers
@mkurz @ihostage
[Gradle] Add option to disable JavaScript routers
8aa539c
@ihostage
Copy link
Member Author

ihostage commented Mar 4, 2024

@ihostage Please take a look at the commits I pushed: I renamed the isChanged supplier to triggerReload, because I think this is a bit clearer and I think it's confusing to have the changed variable and an isChanged supplier. (I kept isChanged in the gradle plugin code however, feel free to rename it also if you think it makes sense there).

I'm ok with this renaming, thanks! 👍

@mkurz mkurz merged commit 078266b into main Mar 4, 2024
18 checks passed
@mkurz mkurz deleted the gradle branch March 4, 2024 12:24
@ihostage ihostage added this to the 2.10.0 / 3.1.0 milestone Mar 4, 2024
@ihostage ihostage removed their assignment Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz left review comments

Assignees
No one assigned
Labels
None yet
Projects
Play 2.10 / 3.1 (subject to change)
Status: ✅ Done
Milestone
2.10.0 / 3.1.0
Development

Successfully merging this pull request may close these issues.

Support Gradle
3 participants
@ihostage @mkurz @aalubin