Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-plop): Correct types #367

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(node-plop): Correct types #367

wants to merge 4 commits into from

Conversation

xeho91
Copy link

@xeho91 xeho91 commented Feb 15, 2023

Hi, I love using your package to improve my workflows. Thanks for it!

While coding something new, I found a few typing issues, so I thought of immediately fixing them.


According to the code from these lines:

both action types - "append" and "modify" - accept pattern property in options (cfg) optionally.


Another one is the incorrectly inherited property path inside AddManyActionConfig from AddActionCOnfig. I've confirmed there, that it is actually not being used at all.

Source:

const cfg = Object.assign({}, defaultConfig, userConfig);

@xeho91 xeho91 changed the title fix(node-plop): Set property pattern to optional in AppendActionConfig & ModifyActionConfig fix(node-plop): Correct types Feb 15, 2023
@crutchcorn crutchcorn self-requested a review February 26, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant