Skip to content

Commit

Permalink
Bump pry-byebug version to ~> 3.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@plribeiro3000
plribeiro3000 committed Jun 1, 2015
1 parent a3016a4 commit 4f2077a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions jazz_fingers.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ Gem::Specification.new do |gem|
gem.add_runtime_dependency "pry-doc", "~> 0.6"
gem.add_runtime_dependency "pry-git", "~> 0.2"
gem.add_runtime_dependency "pry-remote", ">= 0.1.7"
gem.add_runtime_dependency "pry-byebug", "1.3.3"
gem.add_runtime_dependency "pry-byebug", "~> 3.1"
gem.add_runtime_dependency "hirb", "~> 0.7"
gem.add_runtime_dependency "pry-coolline", "~> 0.2"
gem.add_runtime_dependency "awesome_print", "~> 1.6.1"
gem.add_runtime_dependency "awesome_print", "~> 1.6"
gem.add_development_dependency "rubocop"
end

3 comments on commit 4f2077a

@asellitt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this may have reintroduced the compatibility issues seen here: #3 is it possible pin pry-byebug back at 1.3.3?

@plribeiro3000
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you not able to install jazz_fingers?
Whats happening? Because it is working for me. I have it in several repos without any issue.

Can you explain your issue please?

@asellitt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, yeah, installing jazz_fingers is no problem, but this version of pry-byebug doesnt actually work with pry-remote. These issues on pry-byebug and on pry-remote explain it better than i can.

Essentially, with any version of pry-byebug higher than 1.3.3, when you use pry-remote you cant connect to the remote. It looks like in #3 you had pinned it to 1.3.3 but then updated it later. Because this now requires a version 3.1 or higher, I cant pin this to a version that works in my projects gemfile either:

In Gemfile:

  ...snip...
  # This is pinned because of compatibility issues with pry remote.
  # See: https://github.com/deivid-rodriguez/pry-byebug/issues/33
  # And: https://github.com/Mon-Ouie/pry-remote/issues/58
  gem 'pry-byebug', '1.3.3'
  ...snip..

After running bundle install:

Fetching gem metadata from https://rubygems.org/........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
You have requested:
  pry-byebug = 1.3.3

The bundle currently has pry-byebug locked at 3.3.0.
Try running `bundle update pry-byebug`

If you are updating multiple gems in your Gemfile at once,
try passing them all to `bundle update`

Please sign in to comment.