Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed deprecation warning from pandas #1165

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Iximiel
Copy link
Member

@Iximiel Iximiel commented Dec 17, 2024

Description

I am working on some (small) modifications on the python package, while running the tests I found that the python module uses delim_whitespace that is deprecated from pandas2.20, (see the manual)

I used the suggested sep="\s+" option, which should be backward-compatible also with older pandas versions

Target release

I would like my code to appear in release 2.11 (or before?)

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@carlocamilloni carlocamilloni merged commit a43124e into plumed:master Jan 16, 2025
7 of 22 checks passed
@GiovanniBussi
Copy link
Member

@Iximiel could you perhaps backport this to v2.9? If it's a sort of LTS, I guess we should fix these small issues as they appear, at least when it's easy (as it is now)

carlocamilloni added a commit that referenced this pull request Jan 16, 2025
Iximiel added a commit to Iximiel/plumed2 that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants