Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On cpp files with no headers hte check was stuck in the loop #1186

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

Iximiel
Copy link
Member

@Iximiel Iximiel commented Jan 27, 2025

Description

@GiovanniBussi pointed me where to search:

there was this
while((getline < cppfile)>=0) that was stuck (getline returns 0 when the file ends).

In #1183 I created the perfected condition to make this an infinite loop: a .cpp with no includes

And here I added that check.

Target release

I would like my code to appear in release v2.9

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@Iximiel Iximiel mentioned this pull request Jan 27, 2025
7 tasks
@carlocamilloni carlocamilloni merged commit 610ec79 into plumed:v2.9 Jan 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants