refactor, fix and feat: Camera Rotation Handling + setCameraRotation Function #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to Simplify Code:
updateFollowCamRotation
andupdateFollowCamPosition
, to encapsulate camera position and rotation updates. These functions are used in multiple places to reduce code duplication and improve maintainability.Fix
rotateCamera
Behavior:rotateCamera
incorrectly applied incremental adjustments to the camera's rotation (e.g., adding to the existing rotation). This fix ensures the function behaves as intended.New
setCameraRotation
Functionality:setCameraRotation
function to allow explicit control over the camera's rotation. UnlikerotateCamera
, this function directly sets the rotation to the specified values.