Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 RC #318

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

v3 RC #318

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions .devcontainer/devcontainer.json

This file was deleted.

3 changes: 1 addition & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"plugin:prettier/recommended",
"plugin:react-hooks/recommended",
"plugin:import/errors",
"plugin:import/warnings",
"plugin:storybook/recommended"
"plugin:import/warnings"
],
"plugins": ["@typescript-eslint", "react", "prettier", "react-hooks", "import"],
"parser": "@typescript-eslint/parser",
Expand Down
19 changes: 0 additions & 19 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,25 +20,6 @@ jobs:
- run: |
yarn install --frozen-lockfile
yarn release
yarn build-storybook
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# - uses: actions/upload-pages-artifact@v1
# with:
# path: ./storybook-static

# See: https://github.com/actions/deploy-pages
# deploy-job:
# needs: release-job
# permissions:
# pages: write
# id-token: write
# environment:
# name: github-pages
# url: ${{ steps.deployment.outputs.page_url }}
# runs-on: ubuntu-latest
# steps:
# - name: Deploy to GitHub Pages
# id: deployment
# uses: actions/deploy-pages@v1
36 changes: 0 additions & 36 deletions .storybook/Setup.tsx

This file was deleted.

9 changes: 0 additions & 9 deletions .storybook/index.css

This file was deleted.

19 changes: 0 additions & 19 deletions .storybook/main.ts

This file was deleted.

26 changes: 0 additions & 26 deletions .storybook/preview.tsx

This file was deleted.

Binary file not shown.
Binary file removed .storybook/public/lensDirtTexture.png
Binary file not shown.
112 changes: 0 additions & 112 deletions .storybook/public/suzi.gltf

This file was deleted.

91 changes: 0 additions & 91 deletions .storybook/stories/Autofocus.stories.tsx

This file was deleted.

90 changes: 0 additions & 90 deletions .storybook/stories/LensFlare.stories.tsx

This file was deleted.

1 change: 0 additions & 1 deletion .storybook/stories/assets/repo.svg

This file was deleted.

8 changes: 0 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@ You can also just [![Open in GitHub Codespaces](https://img.shields.io/static/v1

Be sure your commit messages follow this specification: https://www.conventionalcommits.org/en/v1.0.0-beta.4/

## Storybook

If you're adding a brand new feature, you need to make sure you add a storybook entry, here's a few tips:

- Keep the story simple & show the essence of the component, remember some people may be looking at using drei for the first time & it's important the stories are clear and concise.
- Keep assets minimal (3D Models, textures) to avoid bloating the repository
- If you think a more involved example is necessary, you can always add a codesandbox to the main README while keeping the story minimalistic

## Publishing

We use `semantic-release` to deploy the package. Because of this only certain commits will trigger the action of creating a release:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ From
> the screen diagonal. This is especially beneficial for GPGPU passes and
> effects that use complex fragment shaders.

Postprocessing also supports srgb-encoding out of the box, as well as WebGL2
Postprocessing also supports gamma correction out of the box, as well as WebGL2
MSAA (multi sample anti aliasing), which is react-postprocessing's default, you
get high performance crisp results w/o jagged edges.

Expand Down
2 changes: 1 addition & 1 deletion docs/introduction.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ From
> the screen diagonal. This is especially beneficial for GPGPU passes and
> effects that use complex fragment shaders.

Postprocessing also supports srgb-encoding out of the box, as well as WebGL2
Postprocessing also supports gamma correction out of the box, as well as WebGL2
MSAA (multi sample anti aliasing), which is react-postprocessing's default, you
get high performance crisp results w/o jagged edges.

Expand Down
Loading
Loading