Fixes page clientsidewebpart add for the vertical sections. Closes #6265
#6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mkm17 for yet another contribution 🤩 |
|
Hi @martinlingstuyl , I marked this PR as a draft because, in my opinion, change #6540 should go first. After that, I will add the handler for vertical sections to all commands, not just the clientsidewebpart one. |
|
Absolutely fine @mkm17, I'll wait till you request a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6265
As mentioned in the title, this update allows adding a web part to the vertical section.
I have added a parameter named
--verticalSectionto handle this case.Could you let me know if this is a good approach to resolve the issue?
I have also applied some recommendations from the previous tasks to this command's test file.
Some code from this command can be reused in the future implementation of
page section remove.